From: Jingoo Han <jg1.han@samsung.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH 1/3] pcmcia: bfin_cf: remove unnecessary platform_set_drvdata()
Date: Thu, 22 Aug 2013 11:16:17 +0900 [thread overview]
Message-ID: <002501ce9edd$95cbb740$c16325c0$%han@samsung.com> (raw)
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pcmcia/bfin_cf_pcmcia.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pcmcia/bfin_cf_pcmcia.c b/drivers/pcmcia/bfin_cf_pcmcia.c
index ed3b522..624d127 100644
--- a/drivers/pcmcia/bfin_cf_pcmcia.c
+++ b/drivers/pcmcia/bfin_cf_pcmcia.c
@@ -281,7 +281,6 @@ fail2:
fail0:
gpio_free(cf->cd_pfx);
kfree(cf);
- platform_set_drvdata(pdev, NULL);
return status;
}
@@ -296,7 +295,6 @@ static int bfin_cf_remove(struct platform_device *pdev)
del_timer_sync(&cf->timer);
iounmap((void __iomem *)cf->socket.io_offset);
release_mem_region(cf->phys_cf_io, SZ_8K);
- platform_set_drvdata(pdev, NULL);
kfree(cf);
return 0;
}
--
1.7.10.4
next reply other threads:[~2013-08-22 2:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 2:16 Jingoo Han [this message]
2013-08-22 2:16 ` [PATCH 2/3] pcmcia: pxa2xx: " Jingoo Han
2013-08-22 2:17 ` [PATCH 3/3] pcmcia: sa1100: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002501ce9edd$95cbb740$c16325c0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®