From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557Ab1HSGvP (ORCPT ); Fri, 19 Aug 2011 02:51:15 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:55720 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746Ab1HSGvN (ORCPT ); Fri, 19 Aug 2011 02:51:13 -0400 X-AuditID: cbfee61a-b7cf1ae00000208e-f4-4e4e07df8c75 Date: Fri, 19 Aug 2011 15:51:11 +0900 From: Kukjin Kim Subject: RE: [PATCH] ARM:EXYNOS4: Add the missing clock of EXYNOS4210 to remove leakage power In-reply-to: <4E425573.30408@samsung.com> To: "'Chanwoo Choi'" , "'Russell King - ARM Linux'" Cc: "'Kyungmin Park'" , "'linux-arm-kernel'" , "'linux-samsung-soc'" , "'linux-kernel'" , dg77.kim@samsung.com Message-id: <002701cc5e3c$61a16e80$24e44b80$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Content-type: text/plain; charset=utf-8 Content-language: ko Content-transfer-encoding: 7BIT Thread-index: AcxXQ7sU10ZTRbvDT0660e/e5TItkwGWa/7g References: <4E425573.30408@samsung.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chanwoo Choi wrote: > > Singed-off-by: Chanwoo Choi > Singed-off-by: Donggeun Kim > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-exynos4/clock.c | 295 > +++++++++++++++++++++++++ > arch/arm/mach-exynos4/include/mach/regs-pmu.h | 6 + > 2 files changed, 301 insertions(+), 0 deletions(-) > mode change 100644 => 100755 arch/arm/mach-exynos4/clock.c > NO. don't change the mode :( And I don't think we _really_ need to add all clocks if they will not be used anywhere in kernel. If it is required, please turn off the clocks in boot loader. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.