From: Jingoo Han <jg1.han@samsung.com>
To: "'Linus Walleij'" <linus.walleij@linaro.org>
Cc: "'Grant Likely'" <grant.likely@secretlab.ca>,
"'Kukjin Kim'" <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
"'Ryan Mallon'" <rmallon@gmail.com>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH V2 RESEND] gpio: samsung: use pr_* instead of printk
Date: Wed, 17 Oct 2012 10:49:10 +0900 [thread overview]
Message-ID: <002701cdac09$9a3b67c0$ceb23740$%han@samsung.com> (raw)
In-Reply-To: <CACRpkdbBuiae=+AXfAEargz0cJEDxa0-yVETw0zpNt_pOkuF4g@mail.gmail.com>
On Wednesday, October 17, 2012 2:33 AM Linus Walleij wrote:
>
> On Tue, Oct 16, 2012 at 10:25 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>
> > int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip,
> > unsigned int off, samsung_gpio_pull_t pull)
> > {
> > @@ -599,7 +593,7 @@ static int samsung_gpiolib_4bit_input(struct gpio_chip *chip,
> > con &= ~(0xf << con_4bit_shift(offset));
> > __raw_writel(con, base + GPIOCON_OFF);
> >
> > - gpio_dbg("%s: %p: CON now %08lx\n", __func__, base, con);
> > + pr_debug("%s: %p: CON now %08lx\n", __func__, base, con);
>
> Does your struct gpio_chip provide a valid dev pointer so you can use:
>
> dev_dbg(chip->dev, "%s: %p: CON now %08lx\n", __func__, base, con);
>
> In that case use the dev_* print macros everywhere instead.
>
No, a valid dev pointer is not provided yet.
After a valid dev pointer is available, I will change
pr_debug to dev_dbg.
Best regards,
Jingoo Han
> Yours,
> Linus Walleij
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-10-17 1:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 8:25 Jingoo Han
2012-10-16 9:43 ` Ryan Mallon
2012-10-17 1:00 ` Jingoo Han
2012-10-16 17:32 ` Linus Walleij
2012-10-17 1:49 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002701cdac09$9a3b67c0$ceb23740$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=grant.likely@secretlab.ca \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®