mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: "'Tobias Klauser'" <tklauser@distanz.ch>
Cc: linux-kernel@vger.kernel.org, "'Suman Anna'" <s-anna@ti.com>,
	"'Tony Lindgren'" <tony@atomide.com>,
	"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH] mailbox/omap: Use module_platform_driver
Date: Wed, 23 Jul 2014 09:52:17 +0900	[thread overview]
Message-ID: <002801cfa610$59eee630$0dccb290$%han@samsung.com> (raw)
In-Reply-To: <1406031223-15759-1-git-send-email-tklauser@distanz.ch>

On Tuesday, July 22, 2014 9:14 PM, Tobias Klauser wrote:
> 
> Use the module_platform_driver to omit module init/exit boilerplate code.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
>  drivers/mailbox/mailbox-omap1.c | 13 +------------
>  drivers/mailbox/mailbox-omap2.c | 13 +------------
>  2 files changed, 2 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/mailbox/mailbox-omap1.c b/drivers/mailbox/mailbox-omap1.c
> index 9001b76..735aeef 100644
> --- a/drivers/mailbox/mailbox-omap1.c
> +++ b/drivers/mailbox/mailbox-omap1.c
> @@ -184,18 +184,7 @@ static struct platform_driver omap1_mbox_driver = {
>  	},
>  };
> 
> -static int __init omap1_mbox_init(void)
> -{
> -	return platform_driver_register(&omap1_mbox_driver);
> -}
> -
> -static void __exit omap1_mbox_exit(void)
> -{
> -	platform_driver_unregister(&omap1_mbox_driver);
> -}
> -
> -module_init(omap1_mbox_init);
> -module_exit(omap1_mbox_exit);
> +module_platform_driver(omap1_mbox_driver);
> 
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("omap mailbox: omap1 architecture specific functions");
> diff --git a/drivers/mailbox/mailbox-omap2.c b/drivers/mailbox/mailbox-omap2.c
> index 42d2b89..a9dedf0 100644
> --- a/drivers/mailbox/mailbox-omap2.c
> +++ b/drivers/mailbox/mailbox-omap2.c
> @@ -337,18 +337,7 @@ static struct platform_driver omap2_mbox_driver = {
>  	},
>  };
> 
> -static int __init omap2_mbox_init(void)
> -{
> -	return platform_driver_register(&omap2_mbox_driver);
> -}
> -
> -static void __exit omap2_mbox_exit(void)
> -{
> -	platform_driver_unregister(&omap2_mbox_driver);
> -}
> -
> -module_init(omap2_mbox_init);
> -module_exit(omap2_mbox_exit);
> +module_platform_driver(omap2_mbox_driver);
> 
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("omap mailbox: omap2/3/4 architecture specific functions");
> --
> 2.0.1



      parent reply	other threads:[~2014-07-23  0:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 12:13 Tobias Klauser
2014-07-22 15:00 ` Suman Anna
2014-07-23  0:57   ` Jingoo Han
2014-07-23  1:24     ` Suman Anna
2014-07-23  7:43   ` Tobias Klauser
2014-07-23  0:52 ` Jingoo Han [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002801cfa610$59eee630$0dccb290$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s-anna@ti.com \
    --cc=tklauser@distanz.ch \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome