From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Julius Bairaktaris <julius@bairaktaris.de>,
Jeff Johnson <jjohnson@kernel.org>
Cc: Baochen Qiang <baochen.qiang@oss.qualcomm.com>,
Vasanthakumar Thiagarajan
<vasanthakumar.thiagarajan@oss.qualcomm.com>,
Manikanta Pubbisetty <manikanta.pubbisetty@oss.qualcomm.com>,
Kalle Valo <kvalo@kernel.org>,
Sriram R <sriram.ramachandran@oss.qualcomm.com>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
ath12k@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH ath-next 0/2] wifi: ath11k/ath12k: drop TKIP frames too short for the Michael MIC
Date: Thu, 12 Nov 2026 10:40:50 -0800 [thread overview]
Message-ID: <002f7e3f-e4e5-4c7b-b683-c2add5b6377c@oss.qualcomm.com> (raw)
In-Reply-To: <20261111080620.244164-1-julius@bairaktaris.de>
On 11/11/2026 12:06 AM, Julius Bairaktaris wrote:
> ath11k and ath12k check the Michael MIC of a reassembled TKIP frame in
> the driver. Both compute the length of the MIC-protected data in a
> size_t without checking that the frame is long enough, so a peer that
> holds the TKIP key and sends two fragments with fewer than 16 payload
> bytes between them wraps the length, and michael_mic() reads on from the
> skb data until it faults. Each patch drops such a frame before the
> subtraction, as mac80211 does in its own MIC check.
>
> I used Claude (Anthropic) to help write these patches.
>
> Julius Bairaktaris (2):
> wifi: ath12k: drop TKIP frames too short for the Michael MIC
> wifi: ath11k: drop TKIP frames too short for the Michael MIC
>
> drivers/net/wireless/ath/ath11k/dp_rx.c | 5 +++++
> drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c | 5 +++++
> 2 files changed, 10 insertions(+)
>
>
> base-commit: d0fbb39d65dc9dcb4175fa6b23e473dec3670f4d
Is this a theoretical change or are you able to have firmware pass too short
frames to the host?
Maintainers are being overwhelmed with "fixes" that are theoretical and which
do not occur with known versions of firmware.
I (and the stable team) need to spend our time on exploitable bugs, not theory.
/jeff
prev parent reply other threads:[~2026-11-12 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 8:06 Julius Bairaktaris
2026-11-11 8:06 ` [PATCH ath-next 1/2] wifi: ath12k: " Julius Bairaktaris
2026-11-11 8:06 ` [PATCH ath-next 2/2] wifi: ath11k: " Julius Bairaktaris
2026-11-12 18:40 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=002f7e3f-e4e5-4c7b-b683-c2add5b6377c@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=julius@bairaktaris.de \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=manikanta.pubbisetty@oss.qualcomm.com \
--cc=sriram.ramachandran@oss.qualcomm.com \
--cc=vasanthakumar.thiagarajan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®