From: Jingoo Han <jg1.han@samsung.com>
To: "'Joe Perches'" <joe@perches.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
"'LKML'" <linux-kernel@vger.kernel.org>,
"'Richard Purdie'" <rpurdie@rpsys.net>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: RE: [PATCH v2 1/7] backlight: use pr_warn instead of printk
Date: Wed, 16 May 2012 16:27:14 +0900 [thread overview]
Message-ID: <003001cd3335$50cc4520$f264cf60$%han@samsung.com> (raw)
In-Reply-To: <1337146157.26509.9.camel@joe2Laptop>
On Wed, 16 May 2012 14:29:00 +0900
Joe Perches <joe@perches.com> wrote:
>
> On Wed, 2012-05-16 at 14:08 +0900, Jingoo Han wrote:
> > This patch uses pr_warn instead of printk to allow dynamic debugging.
>
> A slight mistake in the commit message.
> pr_debug not pr_warn.
>
> > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
> > index bf5b1ec..f7ce212 100644
> > --- a/drivers/video/backlight/backlight.c
> > +++ b/drivers/video/backlight/backlight.c
> > @@ -5,6 +5,8 @@
> > *
> > */
> >
> > +#define pr_fmt(fmt) "backlight: " fmt
>
> I'd prefer:
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Hi, Joe Perches.
Thank you for your comment.
I will fix the commit message and pr_fmt.
Best regards,
Jingoo Han
>
> > diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c
> > index 1c298d5..e61db49 100644
> > --- a/drivers/video/backlight/lcd.c
> > +++ b/drivers/video/backlight/lcd.c
> > @@ -5,6 +5,8 @@
> > *
> > */
> >
> > +#define pr_fmt(fmt) "lcd: " fmt
>
> KBUILD_MODNAME here too
prev parent reply other threads:[~2012-05-16 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 5:08 Jingoo Han
2012-05-16 5:29 ` Joe Perches
2012-05-16 7:27 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003001cd3335$50cc4520$f264cf60$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®