From: Jingoo Han <jg1.han@samsung.com>
To: "'Vinod Koul'" <vinod.koul@intel.com>
Cc: "'Dan Williams'" <djbw@fb.com>,
linux-kernel@vger.kernel.org,
"'Andy Shevchenko'" <andriy.shevchenko@linux.intel.com>,
"'Jingoo Han'" <jg1.han@samsung.com>,
"'Fabio Estevam'" <fabio.estevam@freescale.com>,
"'Shawn Guo'" <shawn.guo@linaro.org>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH] dma: ipu: remove unnecessary platform_set_drvdata()
Date: Wed, 21 Aug 2013 18:52:54 +0900 [thread overview]
Message-ID: <003101ce9e54$35dc8910$a1959b30$%han@samsung.com> (raw)
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/dma/ipu/ipu_idmac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
index 608d4a2..cb9c0bc 100644
--- a/drivers/dma/ipu/ipu_idmac.c
+++ b/drivers/dma/ipu/ipu_idmac.c
@@ -1764,7 +1764,6 @@ static int ipu_remove(struct platform_device *pdev)
iounmap(ipu->reg_ic);
iounmap(ipu->reg_ipu);
tasklet_kill(&ipu->tasklet);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.10.4
next reply other threads:[~2013-08-21 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 9:52 Jingoo Han [this message]
2013-08-22 1:31 ` Shawn Guo
2013-08-25 9:07 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003101ce9e54$35dc8910$a1959b30$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=djbw@fb.com \
--cc=fabio.estevam@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®