From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Axel Lin'" <axel.lin@gmail.com>, linux-kernel@vger.kernel.org
Cc: "'Dave Jones'" <davej@redhat.com>, cpufreq@vger.kernel.org
Subject: RE: [PATCH 2/2] cpufreq: s5pv210: make needlessly global symbols static
Date: Fri, 08 Jul 2011 16:47:34 +0900 [thread overview]
Message-ID: <003201cc3d43$54b12360$fe136a20$%kim@samsung.com> (raw)
In-Reply-To: <1310106276.27158.2.camel@phoenix>
Axel Lin wrote:
>
> The following symbols are needlessly defined global:
> s5pv210_verify_speed
> s5pv210_getspeed
>
> Make them static.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> ---
> drivers/cpufreq/s5pv210-cpufreq.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
> index a7cb338..806408e 100644
> --- a/drivers/cpufreq/s5pv210-cpufreq.c
> +++ b/drivers/cpufreq/s5pv210-cpufreq.c
> @@ -121,7 +121,7 @@ static void s5pv210_set_refresh(enum s5pv210_dmc_port
> ch, unsigned long freq)
> __raw_writel(tmp1, reg);
> }
>
> -int s5pv210_verify_speed(struct cpufreq_policy *policy)
> +static int s5pv210_verify_speed(struct cpufreq_policy *policy)
> {
> if (policy->cpu)
> return -EINVAL;
> @@ -129,7 +129,7 @@ int s5pv210_verify_speed(struct cpufreq_policy *policy)
> return cpufreq_frequency_table_verify(policy, s5pv210_freq_table);
> }
>
> -unsigned int s5pv210_getspeed(unsigned int cpu)
> +static unsigned int s5pv210_getspeed(unsigned int cpu)
> {
> if (cpu)
> return 0;
> --
> 1.7.4.1
next prev parent reply other threads:[~2011-07-08 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 6:20 [PATCH 1/2] cpufreq: exynos4210: " Axel Lin
2011-07-08 6:24 ` [PATCH 2/2] cpufreq: s5pv210: " Axel Lin
2011-07-08 7:47 ` Kukjin Kim [this message]
2011-07-08 7:46 ` [PATCH 1/2] cpufreq: exynos4210: " Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003201cc3d43$54b12360$fe136a20$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=axel.lin@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®