From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752080AbcF1BlT (ORCPT <rfc822;w@1wt.eu>);
	Mon, 27 Jun 2016 21:41:19 -0400
Received: from emcscan.emc.com.tw ([192.72.220.5]:25745 "EHLO
	emcscan.emc.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751942AbcF1BlR convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 27 Jun 2016 21:41:17 -0400
From: =?utf-8?B?5buW5bSH5qau?= <kt.liao@emc.com.tw>
To: "'Daniel Drake'" <drake@endlessm.com>
Cc: "'Dmitry Torokhov'" <dmitry.torokhov@gmail.com>,
        "'Chris Chiu'" <chiu@endlessm.com>,
        "'Charlie Mooney'" <charliemooney@chromium.org>,
        "'Michele Curti'" <michele.curti@gmail.com>,
        "'Krzysztof Kozlowski'" <k.kozlowski@samsung.com>,
        "'Benson Leung'" <bleung@chromium.org>, <linux-input@vger.kernel.org>,
        "'Linux Kernel'" <linux-kernel@vger.kernel.org>,
        "'Linux Upstreaming Team'" <linux@endlessm.com>,
        =?utf-8?B?J+m7g+S4lum1rCDntpPnkIYn?= <phoenix@emc.com.tw>,
        "'jimmy_yang'" <jimmy_yang@emc.com.tw>,
        "'Miller_Wang'" <miller_wang@emc.com.tw>
References: <1465306449-28256-1-git-send-email-chiu@endlessm.com>	<20160620174251.GC22426@dtor-ws>	<008601d1cbba$124c2230$36e46690$@emc.com.tw> <CAD8Lp44NHiSfPjzYkPCm1jX1Jb2E071WY4_OdCpJv0H7ivEoSg@mail.gmail.com>
In-Reply-To: <CAD8Lp44NHiSfPjzYkPCm1jX1Jb2E071WY4_OdCpJv0H7ivEoSg@mail.gmail.com>
Subject: RE: [PATCH] Input: elan_i2c - +200 ms delay before setting to ABS mode
Date: Tue, 28 Jun 2016 09:41:13 +0800
Message-ID: <003401d1d0de$27b8e1c0$772aa540$@emc.com.tw>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: 8BIT
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQKywGA+SkkHjCznp4v5fhf90qzUwwJqLmBNAfmH6esCnego8p4EKbRw
Content-Language: zh-tw
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Daniel, Chris

-----Original Message-----
From: Daniel Drake [mailto:drake@endlessm.com] 
Sent: Tuesday, June 21, 2016 10:42 PM
To: 廖崇榮
Cc: Dmitry Torokhov; Chris Chiu; Charlie Mooney; Michele Curti; Krzysztof Kozlowski; Benson Leung; linux-input@vger.kernel.org; Linux Kernel; Linux Upstreaming Team; 黃世鵬 經理
Subject: Re: [PATCH] Input: elan_i2c - +200 ms delay before setting to ABS mode

On Tue, Jun 21, 2016 at 6:40 AM, 廖崇榮 <kt.liao@emc.com.tw> wrote:
> KT, is this feasible?
> [KT] After internal discussion, we don't agree this patch.
>     It's a work-around to fix firmware bug for specific touchpad and 
> not tested by other device.

For better or worse, Linux often takes on the responsibility of working around firmware bugs. This is a real issue that affects multiple Asus laptops; you'll have no touchpad input upon reboot from any OS that drives the touchpad in "generic hid" mode (e.g. older version of Linux, some embedded OS, etc).

If the sleep is really that controversial, we could make it specific to the ELAN1000 model that is the one in question here?

[KT] : I list all ASUS models with firmware issue which cause TP no function in Endless OOB , please focuses on below types only
     Ic_type : 14
     Product_id : 0x14, 0x15, 0x16, 0x25, 0x18, 0x29, 0x2c, 0x31, 0x32, 0x35

	 You can add if branch in "__elan_initialize", something like that

	 if(data->ic_ytpe == 14 && 
		(data->product_id == 0x14 || data->product_id == 0x15 || data->product_id == 0x16 || 
		data->product_id == 0x25 || data->product_id == 0x18 || data->product_id == 0x29 || 
		data->product_id == 0x2c || data->product_id == 0x31 || data->product_id == 0x32 || data->product_id == 0x35))
	 { //flow for Endless}
	 Else {//original flow}