From: Jingoo Han <jg1.han@samsung.com>
To: "'Andrew Morton'" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
"'Alessandro Zummo'" <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, "'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH V3 11/11] rtc: rtc-cmos: use dev_warn()/dev_dbg() instead of printk()/pr_debug()
Date: Fri, 15 Feb 2013 16:32:11 +0900 [thread overview]
Message-ID: <003501ce0b4e$919e0510$b4da0f30$%han@samsung.com> (raw)
In-Reply-To: <002b01ce0b4d$865ca950$9315fbf0$%han@samsung.com>
Fixed the checkpatch warning as below:
WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
No changes since v1:
No changes since v2:
drivers/rtc/rtc-cmos.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index 9deb9e4..af97c94 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -706,7 +706,7 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq)
rtc_cmos_int_handler = hpet_rtc_interrupt;
err = hpet_register_irq_handler(cmos_interrupt);
if (err != 0) {
- printk(KERN_WARNING "hpet_register_irq_handler "
+ dev_warn(dev, "hpet_register_irq_handler "
" failed in rtc_init().");
goto cleanup1;
}
@@ -731,8 +731,7 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq)
goto cleanup2;
}
- pr_info("%s: %s%s, %zd bytes nvram%s\n",
- dev_name(&cmos_rtc.rtc->dev),
+ dev_info(dev, "%s%s, %zd bytes nvram%s\n",
!is_valid_irq(rtc_irq) ? "no alarms" :
cmos_rtc.mon_alrm ? "alarms up to one year" :
cmos_rtc.day_alrm ? "alarms up to one month" :
@@ -820,8 +819,7 @@ static int cmos_suspend(struct device *dev)
enable_irq_wake(cmos->irq);
}
- pr_debug("%s: suspend%s, ctrl %02x\n",
- dev_name(&cmos_rtc.rtc->dev),
+ dev_dbg(dev, "suspend%s, ctrl %02x\n",
(tmp & RTC_AIE) ? ", alarm may wake" : "",
tmp);
@@ -876,9 +874,7 @@ static int cmos_resume(struct device *dev)
spin_unlock_irq(&rtc_lock);
}
- pr_debug("%s: resume, ctrl %02x\n",
- dev_name(&cmos_rtc.rtc->dev),
- tmp);
+ dev_dbg(dev, "resume, ctrl %02x\n", tmp);
return 0;
}
--
1.7.2.5
prev parent reply other threads:[~2013-02-15 7:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 7:24 [PATCH V3 01/11] rtc: use dev_warn()/dev_dbg()/pr_err() instead of printk() Jingoo Han
2013-02-15 7:25 ` [PATCH V3 02/11] rtc: max77686: use dev_info() " Jingoo Han
2013-02-15 7:26 ` [PATCH V3 03/11] rtc: rtc-efi: use dev_err()/dev_warn()/pr_err() " Jingoo Han
2013-02-15 7:26 ` [PATCH V3 04/11] rtc: rtc-ds2404: use dev_err() " Jingoo Han
2013-02-15 7:27 ` [PATCH V3 05/11] rtc: rtc-rs5c372: use dev_dbg()/dev_warn() instead of printk()/pr_debug() Jingoo Han
2013-02-15 7:28 ` [PATCH V3 06/11] rtc: rtc-at91rm9200: use dev_dbg()/dev_err() " Jingoo Han
2013-02-15 7:29 ` [PATCH V3 07/11] rtc: rtc-rs5c313: use pr_err() instead of printk() Jingoo Han
2013-02-15 7:30 ` [PATCH V3 08/11] rtc: rtc-vr41xx: use dev_info() " Jingoo Han
2013-02-15 7:30 ` [PATCH V3 09/11] rtc: rtc-sun4v: use pr_warn() " Jingoo Han
2013-02-15 7:31 ` [PATCH V3 10/11] rtc: rtc-pcf8583: use dev_warn() " Jingoo Han
2013-02-15 7:32 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003501ce0b4e$919e0510$b4da0f30$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®