mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shawn Guo <shawnguo2@yeah.net>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] ARM: dts: imx6qdl: align pin config nodes with bindings
Date: Mon, 2 Sep 2024 09:55:31 +0200	[thread overview]
Message-ID: <0035a39c-4e9e-4ffd-84f3-dea4835e95c0@linaro.org> (raw)
In-Reply-To: <ZtUPRciha9lSbraF@dragon>

On 02/09/2024 03:05, Shawn Guo wrote:
> On Sat, Aug 31, 2024 at 12:28:21PM +0200, Krzysztof Kozlowski wrote:
>> Bindings for other NXP pin controllers expect pin configuration nodes in
>> pinctrl to match certain naming, so adjust these as well, even though
>> their bindings are not yet in dtschema format.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---


>>  
>> -	pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
>> +	pinctrl_usdhc1_200mhz: usdhc1-200mhz-grp {
>>  		fsl,pins = <
>>  			MX6QDL_PAD_SD1_CMD__SD1_CMD	0x170F9
>>  			MX6QDL_PAD_SD1_CLK__SD1_CLK	0x100F9
>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi
>> index a1ea33c4eeb7..79d80632ee45 100644
>> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi
>> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi
>> @@ -436,7 +436,7 @@ MX6QDL_PAD_SD3_RST__GPIO7_IO08  0x13059
>>  		>;
>>  	};
>>  
>> -	pinctrl_usdhc3_100mhz: usdhc3grp100mhzgrp {
>> +	pinctrl_usdhc3_100mhz: usdhc3-100mhz-grpgrp {
> 
> s/grpgrp/grp?
> 
>>  		fsl,pins = <
>>  			MX6QDL_PAD_SD3_CMD__SD3_CMD	0x170B9
>>  			MX6QDL_PAD_SD3_CLK__SD3_CLK	0x100B9
>> @@ -451,7 +451,7 @@ MX6QDL_PAD_SD3_RST__GPIO7_IO08  0x130B9
>>  		>;
>>  	};
>>  
>> -	pinctrl_usdhc3_200mhz: usdhc3grp200mhzgrp {
>> +	pinctrl_usdhc3_200mhz: usdhc3-200mhz-grpgrp {
> 
> Ditto
> 

Indeed, Thanks. I'll check if I did not make same mistake in other places.

Best regards,
Krzysztof


      reply	other threads:[~2024-09-02  7:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-31 10:28 [PATCH 0/4] ARM: dts: nxp: imx: mnor pinctrl node improvements Krzysztof Kozlowski
2024-08-31 10:28 ` [PATCH 1/4] ARM: dts: imx6ul-tx6ul: drop empty pinctrl placeholder Krzysztof Kozlowski
2024-08-31 10:28 ` [PATCH 2/4] ARM: dts: imx6ul: align pin config nodes with bindings Krzysztof Kozlowski
2024-08-31 10:28 ` [PATCH 3/4] ARM: dts: imx6sl: " Krzysztof Kozlowski
2024-08-31 10:28 ` [PATCH 4/4] ARM: dts: imx6qdl: " Krzysztof Kozlowski
2024-09-02  1:05   ` Shawn Guo
2024-09-02  7:55     ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0035a39c-4e9e-4ffd-84f3-dea4835e95c0@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo2@yeah.net \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®