From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753122Ab1KOHUj (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Nov 2011 02:20:39 -0500
Received: from mailout4.samsung.com ([203.254.224.34]:48393 "EHLO
	mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752946Ab1KOHUi convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Nov 2011 02:20:38 -0500
X-AuditID: cbfee61a-b7cf1ae00000208e-dc-4ec212c5bbfc
From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Axel Lin'" <axel.lin@gmail.com>, linux-kernel@vger.kernel.org
Cc: "'Ben Dooks'" <ben-linux@fluff.org>,
        "'Russell King'" <linux@arm.linux.org.uk>,
        "'Kyungmin Park'" <kyungmin.park@samsung.com>,
        "'Marek Szyprowski'" <m.szyprowski@samsung.com>,
        linux-arm-kernel@lists.infradead.org
References: <1320897382.13190.1.camel@phoenix>
In-reply-to: <1320897382.13190.1.camel@phoenix>
Subject: RE: [PATCH] ARM: SAMSUNG: gpio-cfg.h: include linux/types.h
Date: Tue, 15 Nov 2011 16:20:37 +0900
Message-id: <003601cca367$1266fcc0$3734f640$%kim@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 8BIT
X-Mailer: Microsoft Office Outlook 12.0
Thread-index: AcyfXL8ratvJ/4ItQkeUK5c1/jU2TAECkE5A
Content-language: ko
X-Brightmail-Tracker: AAAAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Axel Lin wrote:
> 
> Include linux/types.h to fix below build error:
> 
>   CC      drivers/power/max8903_charger.o
> In file included from arch/arm/plat-samsung/include/plat/gpio-fns.h:27,
>                  from arch/arm/mach-s3c2410/include/mach/gpio-fns.h:1,
>                  from arch/arm/mach-s3c2410/include/mach/gpio.h:27,
>                  from /home/axel/repos/git/linux-
> 2.6/arch/arm/include/asm/gpio.h:5,
>                  from include/linux/gpio.h:30,
>                  from drivers/power/max8903_charger.c:23:
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:27: error: expected '=', ',', ';', 'asm'
> or '__attribute__' before 'samsung_gpio_pull_t'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:28: error: expected '=', ',', ';', 'asm'
> or '__attribute__' before 's5p_gpio_drvstr_t'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:55: error: expected specifier-
> qualifier-list before 'samsung_gpio_pull_t'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:146: error: expected declaration
> specifiers or '...' before 'samsung_gpio_pull_t'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:154: error: expected '=', ',', ';', 'asm'
> or '__attribute__' before 's3c_gpio_getpull'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:173: error: expected declaration
> specifiers or '...' before 'samsung_gpio_pull_t'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h: In function
> 's3c_gpio_cfgrange_nopull':
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:178: error: '__force' undeclared (first
> use in this function)
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:178: error: (Each undeclared
> identifier is reported only once
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:178: error: for each function it
> appears in.)
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:178: error: expected ')' before
> 'samsung_gpio_pull_t'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:178: error: expected ')' before
> numeric constant
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:178: error: too many arguments to
> function 's3c_gpio_cfgall_range'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h: At top level:
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:197: error: expected '=', ',', ';', 'asm'
> or '__attribute__' before 's5p_gpio_get_drvstr'
> arch/arm/plat-samsung/include/plat/gpio-cfg.h:208: error: expected declaration
> specifiers or '...' before 's5p_gpio_drvstr_t'
> make[2]: *** [drivers/power/max8903_charger.o] Error 1
> make[1]: *** [drivers/power] Error 2
> make: *** [drivers] Error 2
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  arch/arm/plat-samsung/include/plat/gpio-cfg.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/include/plat/gpio-cfg.h b/arch/arm/plat-
> samsung/include/plat/gpio-cfg.h
> index d48245b..df8155b 100644
> --- a/arch/arm/plat-samsung/include/plat/gpio-cfg.h
> +++ b/arch/arm/plat-samsung/include/plat/gpio-cfg.h
> @@ -24,6 +24,8 @@
>  #ifndef __PLAT_GPIO_CFG_H
>  #define __PLAT_GPIO_CFG_H __FILE__
> 
> +#include<linux/types.h>
> +
>  typedef unsigned int __bitwise__ samsung_gpio_pull_t;
>  typedef unsigned int __bitwise__ s5p_gpio_drvstr_t;
> 
> --
> 1.7.5.4
> 

OK, will apply.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.