mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: "Daniel Díaz" <daniel.diaz@linaro.org>,
	shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Thomas Meyer <thomas@m3y3r.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	open list <linux-kernel@vger.kernel.org>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests/intel_pstate: Improve test, minor fixes
Date: Tue, 8 May 2018 14:27:13 -0600	[thread overview]
Message-ID: <00379a47-e35b-c5a3-2f94-4fa3b90921e9@kernel.org> (raw)
In-Reply-To: <1523398277-2066-1-git-send-email-daniel.diaz@linaro.org>

On 04/10/2018 04:11 PM, Daniel Díaz wrote:
> A few changes improve the overall usability of the test:
> * fix a hard-coded maximum frequency (3300),
> * don't adjust the CPU frequency if only evaluating results,
> * fix a comparison for multiple frequencies.
> 
> A symptom of that last issue looked like this:
>   ./run.sh: line 107: [: too many arguments
>   ./run.sh: line 110: 3099
>   3099
>   3100-3100: syntax error in expression (error token is \"3099
>   3100-3100\")
> 
> Because a check will count how many differente frequencies
> there are among the CPUs of the system, and after they are
> tallied another read is performed, which might produce
> different results.
> 
> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>

Applied to linux-kselftest fixes for 4.17-rc5

thanks,
-- Shuah

      reply	other threads:[~2018-05-08 20:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 22:11 Daniel Díaz
2018-05-08 20:27 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00379a47-e35b-c5a3-2f94-4fa3b90921e9@kernel.org \
    --to=shuah@kernel.org \
    --cc=daniel.diaz@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=shuahkh@osg.samsung.com \
    --cc=tglx@linutronix.de \
    --cc=thomas@m3y3r.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®