From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [121.127.44.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3A0A1854 for ; Fri, 7 Mar 2025 00:05:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=121.127.44.59 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741305948; cv=none; b=HyCq2NnUHgyTQH3zTX/i9riX27CYJE5V/yd6QyOSNYxYMPCE2UQEO66FO+eRldn55lyPM9h688fBwVkHjubrLQDEN5QqiQuIVfzY5r6hehVqdbHAjFEtpPSFYJ9+fHysc1GaHikh3Vn+dQGS4Md3imB66ImTMMMgu4iDJlTF1Ls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741305948; c=relaxed/simple; bh=3xzndWS90lxvRgrGpXolhhCHNJh+cKO5OpPa3qNLBvU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ld55u1SsgQJroW4rpIWKJqxPNf0bEx8d2nQpP0hvgmGdMMUK9jIcBJcNzBpkqvYZIxpwjwv+c3tpUdNuink3gbqhmSi8lX4E0WFSj6SYfoDNtGnV3wR0rkRM5kAwO5HTSaKN9pdHx73ZRgFr3rcwamzdRV1SF5xdRcYll8nLjUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=ViDQJMYY; arc=none smtp.client-ip=121.127.44.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="ViDQJMYY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1741305945; bh=q8v6FqGBLcIgD0IKorolr/eW5VRYMlf3vVnAR1Zl+FQ=; b=ViDQJMYYdD+Pq6EMZf3OAvr3RCwVvT223n+2a9nOCtD/fjtAW63b1b0ibzAXEdD01Tzu8q5X8 XMkiU5JGZ8uW8Yo8bXSeJxmKh5x1gJKmBfFGcEP2kCfcZt2/tn8mPBrl3vCTq0GRsZ0MI7hHLy5 Z9/FU586O36+yLvB3l2hak0OBrueIZ08p79NdcjsKl/2HZXfdctTh+QaIb/ZxbLapQ7wNcjdtGn pGLL8sTSwRPGAW93avhaJvK3USxXdRU9YQo/sLHrxGK7G19uVbkapN2LJ7MVpxrKcF9bEq+uYvO ivE68qeJ4gVemgltd4Odg+x87P9IGcSlOAvAMEXnnh0w== X-Forward-Email-ID: 67ca3854d01a7bf632cb828f X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 121.127.44.59 X-Forward-Email-Version: 0.4.40 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Message-ID: <003d3726-680a-4e91-89cd-d127bc3b5609@kwiboo.se> Date: Fri, 7 Mar 2025 01:05:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: rockchip: Add GMAC nodes for RK3528 To: Andrew Lunn Cc: Heiko Stuebner , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yao Zi , linux-rockchip@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250306221402.1704196-1-jonas@kwiboo.se> <20250306221402.1704196-4-jonas@kwiboo.se> Content-Language: en-US From: Jonas Karlman In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Andrew, On 2025-03-06 23:46, Andrew Lunn wrote: > On Thu, Mar 06, 2025 at 10:13:56PM +0000, Jonas Karlman wrote: >> Rockchip RK3528 has two Ethernet controllers based on Synopsys DWC >> Ethernet QoS IP. >> >> Add device tree nodes for the two Ethernet controllers in RK3528. >> >> Signed-off-by: Jonas Karlman >> --- >> gmac0 is missing the integrated-phy and has not been tested bacause I do >> not have any board that use this Ethernet controller. > > What do you know about the integrated PHY? Does it use one of the > standard phy-modes? RMII? Does the datasheet indicate what address it > uses on the MDIO bus? If you know these two bits of information, you > can probably add it. The SoC datasheet lists following: MAC 10/100/1000 Ethernet Controller (gmac1) - Support 10/100/1000 Mbps data transfer rates with the RGMII interfaces - Support 10/100 Mbps data transfer rates with the RMII interfaces - Support both full-duplex and half-duplex operation - Supports IEEE 802.1Q VLAN tag detection for reception frames - Support detection of LAN wake-up frames and AMD Magic Packet frames - Support checking IPv4 header checksum and TCP, UDP, or ICMP checksum encapsulated in IPv4 or IPv6 datagram - Support for TCP Segmentation Offload (TSO) and UDP Fragmentation Offload (UFO) MAC 10/100M Ethernet controller and MAC PHY (gmac0) - Support one Ethernet controllers - Support 10/100-Mbps data transfer rates with the RMII interfaces - Support both full-duplex and half-duplex operation and vendor kernel use following DT node: phy-mode = "rmii"; clock_in_out = "input"; phy-handle = <&rmii0_phy>; mdio0: mdio { compatible = "snps,dwmac-mdio"; #address-cells = <0x1>; #size-cells = <0x0>; rmii0_phy: ethernet-phy@2 { compatible = "ethernet-phy-id0044.1400", "ethernet-phy-ieee802.3-c22"; reg = <2>; clocks = <&cru CLK_MACPHY>; resets = <&cru SRST_MACPHY>; phy-is-integrated; pinctrl-names = "default"; pinctrl-0 = <&fephym0_led_link &fephym0_led_spd>; }; }; I could possible add something like that to the device tree, or I could drop the entire gmac0 node and instead have it added in a future series. Regards, Jonas > > Andrew