From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E0F33290A1 for ; Mon, 30 Mar 2026 15:10:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774883407; cv=none; b=D4YYmCTW0X6ca/KPf7LRyLBOZ70C4Ro7y8s/EeJLddh+3E6vQjz2vgC4cjUnYM5LM5hcBYOvXsTl+B0MoYe5R9qPtXQLktQJnhqrWykKyFcyUSiuvuWI5WaXFcdmY1/WohAAuW0npMW4I9pHnObZeUdSYu8H8Rh5eVdz/pZD4iE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774883407; c=relaxed/simple; bh=9HYSmJ2RT+DLvPtdgYC6b258m85wJEBf4T37DcwFLXs=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=onLYDlLIjGrcr8AjuD2Rh33IEQYkSerG4jEdb0mONXi0JH6yDLle/0VB1GbEG7AykscuJs0tbpjG8etYNN4J/Jpi3sablkINAPa3leVNtNmVSoBIKUsgW0vBEZHq0IO87IRWueMvEmYvyWTHmF/IZmw4UvDNtU905UauJdWiPos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lVWgVq9R; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e5+U38CX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lVWgVq9R"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e5+U38CX" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UF8YfA3539578 for ; Mon, 30 Mar 2026 15:10:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FsgqpyQEAnNrXt+bbNBhoyzyAd06bny381PhksF9wKs=; b=lVWgVq9Rw4kzcaW/ FSFjhocbEa7rPyNalPxbtj8dMWWVmjMX4sd8DgMHeMwqWgybttqBppv8cp+GQJU9 1UcM3Ipn5S4sevvhVujhJQoK0C3uNtjNNFlWhDa2a1HnsVmmhKQ7VATTXbhJYv/j 5M7W7rM8PZ+MorWkqcj3Z+aBEP0rZVlgPCvRWvElTZwYCKrp2oGnTXKAfw6fQ27E 2iwtN+dCs9+MED++zGlhp9+vSVuT8stKR1nsbMWusIUiSYnp0HCiqX8UFjCm+5sM X8ASjLaH1IrxvkYcOcJN19ddh8KN8XE0xgDmum1aiRbPD3izPlA541GUCEB8Q4oW OvlEpA== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7q59s722-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 15:10:05 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-5ffba307845so8236412137.1 for ; Mon, 30 Mar 2026 08:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774883404; x=1775488204; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=FsgqpyQEAnNrXt+bbNBhoyzyAd06bny381PhksF9wKs=; b=e5+U38CXaHh/Yo9tfEYX1X+tWIQEOkxIMpgAmzwhigM9K3BHnKdcl+E2kMj0yrWsEJ o00nP36iIU9QfkJjBEVJZgnMpgtFguNt97FajRmw6WAS7KSuHoa/l9UJMaPkFS5wa/FX VWf3rXA4FGAASjhR+HaOpxCYsA+XEMS+zMBn9X2ydGsI6uJEk05E0tjEz9N364PhEUw+ KPp3dBd/tTVRQivFdpsoVR5Qu+dEPjV33PSFU4afh5ywYry0l8g4KGyrsB6hGpW+i2ZZ o5+DK81isvhL5DSyyXwcjLK8yLV/nvN5nEBUV9/GtNfTC4D8KlBrvkYfF5GZgiEIR8CB kzXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774883404; x=1775488204; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FsgqpyQEAnNrXt+bbNBhoyzyAd06bny381PhksF9wKs=; b=pdSmpawHOH50LRVWiuwDX7YYeqnu1ZrkWys6sMdMitRRnlWWLEbR9izBdILhNJ/cCM 4/naRH8LNLzZgRUT+YN+nBFUWO7U19LDWbcWGpQAu5lc/PdI1ank4ub2Jkf66dpOqOBm wP47u+G25MgH//iJPrFsD5NS2MWCwu42EVM3uOzlho2nMZK3VbDThsxqzU6dGXbBeJ/q i1cTrhDTIZ0kY58qh9NlfL9zTojIZaL/umzKaAQoL5IhlsNMvbqb3tSGr2Y9YqLj30a7 z2cGJ+SKVp/2UOwrouRBNC1rOGlX7B2JDjIZNlDgGngvU+ABFqPWRASHKn61++8PDHV5 Wm5w== X-Forwarded-Encrypted: i=1; AJvYcCWoeagZPduBm7VU+IsjYrkphDNGKJpuw/OHpwvZW2Q+/RT8CgZzkQkAHmnhNd1S06L1xdXjwqU/QMVRT48=@vger.kernel.org X-Gm-Message-State: AOJu0YxOd7xSuhu1gjrPqnj7sHSWguj1P9CCeIe8iDpW+epZxja3RstV s3ZZbRyaMn41HhpLi5pxuJrubO8aXxIMUtIrQAqFT8AWzJzfwclRDHurymLdkXytRzDzIq3l+Rs mgg+sdJLmv6/ID04MaKDNClbpyQWtLK6lHs1lGSA4xFy3/aUV8Evd5o05AZDK31mPE/E= X-Gm-Gg: ATEYQzyNaygSlyc3IvgrHdPthjDHUg2YX9xLOAuODf9W4cFezkgkupQFpv68Ijj5N8M KYa0pfAvopIZNy14onVn4q7K8zrhQ7/LqbM8VzBVrjcp76004JoVbgcBj0fOJc4bHnPI++BCiRT C8YL+zG3VoX9sRCUFF4rXWDzRvjkYKVuaw1zwZjAX0hi7ODobE/Vhqy4XfzLR24c295DlVnRDAW j8gyAyM4umlnpdie89GfeyLg8XJRT7QIddR1fhe7t6u8jJSUr6UPoAweDz16zMyrjBVzNjpwZd/ WvvouQ7/Jm40E0WLmTL0kAXzQBbEs8fHV3aAlAsAl18LfMPwKInjLJCeFRbUfehvhL5BDjccshg hLHIqaFQOKXodzoiW8JEgliQIVHI/oZJnxmrGZHr9M/ffvGHaod35RnFMrTL8j4WP7bTcSIvTO8 7oI7kKf+WqKStzVf0zOgQ/P/Qel15jKz6HLmkMoK6T12FPtVbU2mR2ll2+vdfc8RhSnevSHTF9s 4UjzlB/K78HFRvg X-Received: by 2002:a05:6102:2c1a:b0:602:d52:a32b with SMTP id ada2fe7eead31-604e4e7d628mr5908285137.21.1774883404245; Mon, 30 Mar 2026 08:10:04 -0700 (PDT) X-Received: by 2002:a05:6102:2c1a:b0:602:d52:a32b with SMTP id ada2fe7eead31-604e4e7d628mr5908263137.21.1774883403745; Mon, 30 Mar 2026 08:10:03 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66b72a6ec5csm2606254a12.9.2026.03.30.08.10.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 08:10:02 -0700 (PDT) Message-ID: <003d96ba-3287-4290-8c08-a4e363850c64@oss.qualcomm.com> Date: Mon, 30 Mar 2026 17:10:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans de Goede Subject: Re: [PATCH v2 resend] driver core: Make deferred_probe_timeout default a Kconfig option To: Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich Cc: Rob Herring , Bjorn Andersson , linux-kernel@vger.kernel.org, Saravana Kannan References: <20260314084916.10868-1-johannes.goede@oss.qualcomm.com> Content-Language: en-US, nl In-Reply-To: <20260314084916.10868-1-johannes.goede@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: KHCZwA5x6zkh0dSdxI3Pwf_d1p8ehzNe X-Proofpoint-GUID: KHCZwA5x6zkh0dSdxI3Pwf_d1p8ehzNe X-Authority-Analysis: v=2.4 cv=EcXFgfmC c=1 sm=1 tr=0 ts=69ca924d cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=XZSsNbh3X56fpEbAD7UA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDExOSBTYWx0ZWRfX2zPxEtWo0EoP y6oDvWEGFah2l4HEqkJFVsmPAPle8YQvhAf1WRdo6TE/Xa/mYloJACsG5xFpbE8HvkV0azqtGr/ kDF2YhcrlYqEDKqHQMiLp15sNGcveA/XZ07ojFgV2zbAHZMEdFlw8dOZu+pQ1pe4t6McR/EzLXW kVciRqzoBrjGVBAOSSgyvx/bzFNnN1BecxvRaZrBXbe1yATDcAmMDYfdn9ip/Bv+aPP9OXJBabj 4K9Uj3aywxOv/WUyc1rcpSgMOsQ6km/C9zNFPS1bfgrzRu9CCTBbhnpvY2QQZiOtUxqPCEnrLzE /PvgXmyeR8a7X8GtpmgZULk7cf+GBNleRNu2TcQD4SFOAggKyRLQtxMokOJr6J6G3KgVx68N2Dx I94qQ70+oScnqhDwlCszq3ctuomH/ZrrYcNgXjXIbOv896GjpqnfBbxNK8/zF7axu2NKoSaHtTu gJ2CGoukyZzQA1UvvHQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300119 Hi All, On 14-Mar-26 09:49, Hans de Goede wrote: > Code using driver_deferred_probe_check_state() differs from most > EPROBE_DEFER handling in the kernel. Where other EPROBE_DEFER handling > (e.g. clks, gpios and regulators) waits indefinitely for suppliers to > show up, code using driver_deferred_probe_check_state() will fail > after the deferred_probe_timeout. > > This is a problem for generic distro kernels which want to support many > boards using a single kernel build. These kernels want as much drivers to > be modular as possible. The initrd also should be as small as possible, > so the initrd will *not* have drivers not needing to get the rootfs. > > Combine this with waiting for a full-disk encryption password in > the initrd and it is pretty much guaranteed that the default 10s timeout > will be hit, causing probe() failures when drivers on the rootfs happen > to get modprobe-d before other rootfs modules providing their suppliers. > > Make the default timeout configurable from Kconfig to allow distro kernel > configs where many of the supplier drivers are modules to set the default > through Kconfig. > > While at it document that a value of -1 can be used to disable the timeout > (wait indefinitely). > > Acked-by: Saravana Kannan > Signed-off-by: Hans de Goede gentle ping ? AFAICT there is no reason to not merge this ? Regards, Hans > --- > Changes in v2: > - Remove unnecessary addition of "if (driver_deferred_probe_timeout < 0)" > check > - Add Acked-by from Saravana > --- > Resending as this one seems to have fallen through the cracks. > --- > Documentation/admin-guide/kernel-parameters.txt | 2 +- > drivers/base/Kconfig | 9 +++++++++ > drivers/base/dd.c | 6 +----- > 3 files changed, 11 insertions(+), 6 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index aa0031108bc1..d26957741713 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -1250,7 +1250,7 @@ Kernel parameters > out hasn't expired, it'll be restarted by each > successful driver registration. This option will also > dump out devices still on the deferred probe list after > - retrying. > + retrying. Set to -1 to wait indefinitely. > > delayacct [KNL] Enable per-task delay accounting > > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig > index 1786d87b29e2..f7d385cbd3ba 100644 > --- a/drivers/base/Kconfig > +++ b/drivers/base/Kconfig > @@ -73,6 +73,15 @@ config DEVTMPFS_SAFE > with the PROT_EXEC flag. This can break, for example, non-KMS > video drivers. > > +config DRIVER_DEFERRED_PROBE_TIMEOUT > + int "Default value for deferred_probe_timeout" > + default 0 if !MODULES > + default 10 if MODULES > + help > + Set the default value for the deferred_probe_timeout kernel parameter. > + See Documentation/admin-guide/kernel-parameters.txt for a description > + of the deferred_probe_timeout kernel parameter. > + > config STANDALONE > bool "Select only drivers that don't need compile-time external firmware" > default y > diff --git a/drivers/base/dd.c b/drivers/base/dd.c > index bea8da5f8a3a..2f358e29e0e8 100644 > --- a/drivers/base/dd.c > +++ b/drivers/base/dd.c > @@ -257,11 +257,7 @@ static int deferred_devs_show(struct seq_file *s, void *data) > } > DEFINE_SHOW_ATTRIBUTE(deferred_devs); > > -#ifdef CONFIG_MODULES > -static int driver_deferred_probe_timeout = 10; > -#else > -static int driver_deferred_probe_timeout; > -#endif > +static int driver_deferred_probe_timeout = CONFIG_DRIVER_DEFERRED_PROBE_TIMEOUT; > > static int __init deferred_probe_timeout_setup(char *str) > {