From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Gerald Schaefer'" <gerald.schaefer@de.ibm.com>,
"'Andrew Morton'" <akpm@linux-foundation.org>,
"'Naoya Horiguchi'" <n-horiguchi@ah.jp.nec.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
"'Michal Hocko'" <mhocko@suse.cz>,
"'Kirill A . Shutemov'" <kirill.shutemov@linux.intel.com>,
"'Vlastimil Babka'" <vbabka@suse.cz>,
"'Mike Kravetz'" <mike.kravetz@oracle.com>,
"'Aneesh Kumar K . V'" <aneesh.kumar@linux.vnet.ibm.com>,
"'Martin Schwidefsky'" <schwidefsky@de.ibm.com>,
"'Heiko Carstens'" <heiko.carstens@de.ibm.com>,
"'Dave Hansen'" <dave.hansen@linux.intel.com>,
"'Rui Teng'" <rui.teng@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 1/1] mm/hugetlb: fix memory offline with hugepage size > memory block size
Date: Thu, 22 Sep 2016 15:58:15 +0800 [thread overview]
Message-ID: <003e01d214a7$13a72220$3af56660$@alibaba-inc.com> (raw)
In-Reply-To: <20160921143534.0dd95fe7@thinkpad>
>
> dissolve_free_huge_pages() will either run into the VM_BUG_ON() or a
> list corruption and addressing exception when trying to set a memory
> block offline that is part (but not the first part) of a hugetlb page
> with a size > memory block size.
>
> When no other smaller hugetlb page sizes are present, the VM_BUG_ON()
> will trigger directly. In the other case we will run into an addressing
> exception later, because dissolve_free_huge_page() will not work on the
> head page of the compound hugetlb page which will result in a NULL
> hstate from page_hstate().
>
> To fix this, first remove the VM_BUG_ON() because it is wrong, and then
> use the compound head page in dissolve_free_huge_page().
>
> Also change locking in dissolve_free_huge_page(), so that it only takes
> the lock when actually removing a hugepage.
>
> Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
> ---
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
next prev parent reply other threads:[~2016-09-22 8:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 15:53 [PATCH 0/1] memory offline issues " Gerald Schaefer
2016-09-20 15:53 ` [PATCH 1/1] mm/hugetlb: fix memory offline " Gerald Schaefer
2016-09-21 6:29 ` Hillf Danton
2016-09-21 12:35 ` [PATCH v2 " Gerald Schaefer
2016-09-21 13:17 ` Rui Teng
2016-09-21 15:13 ` Gerald Schaefer
2016-09-22 7:58 ` Hillf Danton [this message]
2016-09-22 9:51 ` Michal Hocko
2016-09-22 13:45 ` Gerald Schaefer
2016-09-22 16:29 ` [PATCH v3] " Gerald Schaefer
2016-09-22 18:12 ` Dave Hansen
2016-09-22 19:13 ` Mike Kravetz
2016-09-23 10:36 ` Gerald Schaefer
2016-09-23 6:40 ` [PATCH v2 1/1] " Rui Teng
2016-09-23 11:03 ` Gerald Schaefer
2016-09-26 2:49 ` Rui Teng
2016-09-20 17:37 ` [PATCH 0/1] memory offline issues " Mike Kravetz
2016-09-20 17:45 ` Dave Hansen
2016-09-21 9:49 ` Vlastimil Babka
2016-09-21 10:34 ` Gerald Schaefer
2016-09-21 10:30 ` Gerald Schaefer
2016-09-21 18:20 ` Michal Hocko
2016-09-21 18:27 ` Dave Hansen
2016-09-21 19:22 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003e01d214a7$13a72220$3af56660$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rui.teng@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®