From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A43A2797AC for ; Tue, 23 Jun 2026 07:37:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782200237; cv=none; b=RTNKv6cYYrJsJavJyZY/4m3jsV9HRzhLPUMnWgXiJqk5xoLmQ227RWzsRabXsug0P1P+PniGwn2+1q1O2szkVM7T/eM4ZDZ+sZ7TkDR6SRbe9wWmLnnwMiPJWjH20j5+tfAL8ckn7DL3UWxSkxOXgbcpxMJEUzGFxu8n7xx97uU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782200237; c=relaxed/simple; bh=QOCpcMEw56ji54fCFwYkjpHPwR/ydyBCSRQofq+lBK4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dx58tk8Laz86I4WbtfkPyXbNQypGHk3XdgJfX5fRojQmfy6CGbXbsYjMIaz2WLjaRjILwRn82xI3SpT2B24GkuDP2lfpx2O6Zln6Kd0a5iQSfN3kg7N0cjJT16trOLflcc4WqfTsRCCXY1iWDGn5NCUaoC7PgeDeaHTSyEkdDzg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cyA4lG35; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R4KbiEL0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cyA4lG35"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R4KbiEL0" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N6d7HQ3376107 for ; Tue, 23 Jun 2026 07:37:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= saKpAUAm0YHRCWzitG4zcz7/l09UJ7iL8naDnDZT5rc=; b=cyA4lG35tS9U/fWd SQzw7tDRJiw6tglVKpCG1kv/qVni+i+KLAOd/lrQFlr1Aj5h/UPJrKcbzTVJU16Y 2eTHkQHAf1nGW81lOxMK2IUMs/GAu5mEQWS1Z6r+Chqy43eAAyjKyLuTaPsij429 cBzSmybAIYQNOg82pZ37mJSIi/CwaD60N56VEpbYjvBsrsnciqhYaVClwld6cOHD M6TEr8EhTz8sWoc1FjjCvjFN85c4pFR0qo37eCFsBS8DtM0lR0bUTZs9zhlCTQIg D0PNkuFtXxMMuxa+dv188naG1m9yiTQk294F2sH9RVMjLnqFwyS69I4kdDVYkXB2 toxI2Q== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey5yebgrn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 07:37:14 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8de715f6ebfso12834306d6.2 for ; Tue, 23 Jun 2026 00:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782200234; x=1782805034; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=saKpAUAm0YHRCWzitG4zcz7/l09UJ7iL8naDnDZT5rc=; b=R4KbiEL0TYitqiyTaFe/Tfl1CYMdndJeF/Q1Vju6nWmHfeTJTb+txDjgkOap0ue54W ai+3DIYxHCPHxU5U/tqEa+9NhS9DacQssbGWwgcqkS7REiv/EKjwm5fytme72O9akCh+ aKhKmtLC56ATqOXoWxLC+gXNrDFpVoRApebnbYPRaN1B+eo2lyDaJylYD9+foOAjgViV lQsqMxmGsCBzuMwX2v2V14IyyX2quX8eWbRbseUnIf9THmdUNbcJz1xbXuwQxprWXVpm vjn6SQHHz3sevhW4gqE3nMHSTG+DtExAoWHsZ84F3OCGAGo1E9Mk2aVy4XRyhN/o5Hb+ NbkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782200234; x=1782805034; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=saKpAUAm0YHRCWzitG4zcz7/l09UJ7iL8naDnDZT5rc=; b=C61xeIsGPcKxeaAP3FfTV6unK8gA1UNcW2pHnVh9F+sTbG0PgGariA0Z5gZ2iG+jAr OKx5P4dpKm1Ajsmz77xlk3U3TAMF2bOdUGYJMFPFVV3a8KOJQ79C9JSr4osBHeBpMfqT yGzz6FBIvrWcO5TO0sjNViXIZiJqHYp90XJcmufU7hvXjLn0PAIZ51hxGXMNK+ttHqut EXyV1UNWCpH2vtZDirmcxb5H7DGj1mjgH06dU4xe31BctA0IWKLEDOsjwk4X+prb7s6T HfXMugxkdWdl7dvm5RnkIxR5ffxaVZSatMbcWUK/qWTl1NVNzXbhW/aspgKmIcETB18s dKkg== X-Forwarded-Encrypted: i=1; AFNElJ/pWwc8MlYVulARdLBzM/Cw/5/gcEhUesRMSaCqfmhwLJ66rAasVJiq/o0qlRFlP0rC/ooeL5s7ujcWZzk=@vger.kernel.org X-Gm-Message-State: AOJu0YzYQnO8+xxUYsMo7TqSCaUgS6xeoDt/4Ind71FDcW7XseoBkG+V 6LKWsIrMDVW+DdYFnwSI/hSEefdLSLYtgr9A84rsDHsW/htW+OPiMCqi7ss5C/LJOft9pT6tWSL epTyQZbuFUHAa6g2DdBH0dbwSROnPtlAbgQxz+R3spEXOVDMeFc44q+6FcwVa77ImFnE= X-Gm-Gg: AfdE7cn1vtNraLM6qVRE38oAq33Dz3FH3dwSHeo6O+MDm1PJ9bdfc57gvh7oMUXTI3s O7ptJcLPQxo50cK7wyil5cqNLTr/G63cywm2LtvuRLq3I4AMOJ0gh6YLk7PTxQuojBpA+irhXQA 3FE79cQz60BAsPvtBgE6BjGxMxsR7LLdSntTVmWy6UfA+sjaIgxAoqjz3HgBAgG6Ce3Uwf3Xgzw XEaFA6l4SJGK95rX+ZTDV25v+xRMzU40Mzi/jiFGdnzoFaWssMqOs9Nf+/VpXzhdEgRjYPsG0LX JxXCnv0c+nzbvFpCI5ytc2W6FmnP+8fOUNsfn3zLf32C9E12dOt8Ocralf0aX9B0o6vYqqqkd0p Kf7MGTZc79wdN0GDIkk7FPeks9V39Za521pQ= X-Received: by 2002:a05:620a:4550:b0:8d3:f6c2:5196 with SMTP id af79cd13be357-925cad55e47mr428063885a.5.1782200233818; Tue, 23 Jun 2026 00:37:13 -0700 (PDT) X-Received: by 2002:a05:620a:4550:b0:8d3:f6c2:5196 with SMTP id af79cd13be357-925cad55e47mr428061885a.5.1782200233416; Tue, 23 Jun 2026 00:37:13 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c5e497fc3sm464765366b.8.2026.06.23.00.37.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 00:37:12 -0700 (PDT) Message-ID: <003e16fc-4179-42c8-ba79-8d37eb92192e@oss.qualcomm.com> Date: Tue, 23 Jun 2026 09:37:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] phy: qcom: edp: split power-on sequencing by PHY version To: Bjorn Andersson , Vinod Koul , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260622-glymur-edp-phy-v1-0-814b45089ac9@oss.qualcomm.com> <20260622-glymur-edp-phy-v1-1-814b45089ac9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260622-glymur-edp-phy-v1-1-814b45089ac9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: pAhJJOLmEGe01dT9ulalyUdo_K60TlUv X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA1OSBTYWx0ZWRfXzMFLWrJgubSB Z0SPFtOL1s+aLxS17ZVMN8VT2sH638GXaUyTum7BP0OIlaXUO0a51dTrh0e+TJACgLJ6xYXwD9h W0p3DPRm/np3Bvs9Ro0KlqNokqx73FI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA1OSBTYWx0ZWRfXzoVMfJ/oxy26 8FQjxtwS2jwnxWiID2jZellad6JhOgk/j31nYdrdCxLf1gQI8ytb9dMTa3nDnWvGN60B1KkNwA/ aQgPRyU4M/hSkrAerlzxRz5aTMBIximr14IKFXZAhg/AIOR6+ATscdVlY7AyeKhUKNyZUJKXcUQ h9Trlf8KBGbamHu5KoJrTnaf8FwP6PH8w6CJdZvNXkCf0AUsv6TsZXrjwMqmLYWoDAwgtvlG6Gj 1jMxreEJNpdHkCJG9POJc91lgDD9+mvsqhuqXAPxae7+OP2YAKRiHNjlEGfctJUA/1eCuhOdemP d/2Ku5y+OPdCCJelH/FtgHYcpoRbPKLxNu4XHGNFuyfPpZWFZ+BW90Vmf8ff3iwx7nzVykIQdnK OfemKgAjZXxiETSWctjotussCRgOYeFvdTDI1h04lDnopayA1Fd7qn9wxZjOcof7jv8+Islp5R2 iQ/z/yRHReRBcLTvEYA== X-Proofpoint-GUID: pAhJJOLmEGe01dT9ulalyUdo_K60TlUv X-Authority-Analysis: v=2.4 cv=YpI/gYYX c=1 sm=1 tr=0 ts=6a3a37aa cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=GWZ8nXm4iHO08dpYRpsA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230059 On 6/23/26 1:29 AM, Bjorn Andersson wrote: > The eDP PHY power-on sequence has grown version-specific differences, > but qcom_edp_phy_power_on() still contains the sequence as one shared > flow. This makes it difficult to add newer PHY programming without > interleaving it with the v4/v6 sequence. > > Split the power-on sequence into version callbacks for the parts that > differ between PHY revisions: > > - pre-power-on preparation > - TX programming before PLL enable > - rate/PCS programming > - lane programming after PLL enable > - final status polling > > Keep the existing v4/v6 sequence as the v46 implementation, and wire v8 > to the same callbacks for now. This keeps the programming unchanged > while making the next patch a v8-only programming update. > > Assisted-by: Codex:GPT-5.5 > Signed-off-by: Bjorn Andersson > --- Look like indeed it's a NOP, as hard as it may be to deduce from the diff: Reviewed-by: Konrad Dybcio Konrad