From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A2C91EE7C6 for ; Wed, 21 Jan 2026 14:28:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769005708; cv=none; b=KLB2AYyRu23B9ydU+68OAoh+1BYkRaUByZeuPo34PvwmSOCZwOtqwclCgfoR79K4Reimdr2rT1gD1O4As89yFyL+Qzicux2VhP1rfAfOq6qd1r9P4R3H/8vrKilyFi3l7F2T6VC9grRMk8lr5gmhMiSBGLqGP6VnRi/OD4vWbno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769005708; c=relaxed/simple; bh=W47neQRs6KW274PsGCHaS4Pdq/oj18A8VCqxZkjWcBw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p9JuT+hne4yXkGAkSLGFZVnoboytQTLIjihbu86nKCFtmFZR6ND8VNTYJvYvAkHakyee0ybd2+Tvw7YuVs4kkapk4leK1ETZny1t+eXeyt5Vni8vMCgNNcR9ooskZjJpSMkEwE6BkP/sOWIpoyUwkbWJCIB/6uvWyl3/kMVxpWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tA0Tk7jF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tA0Tk7jF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CDE1C4CEF1; Wed, 21 Jan 2026 14:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769005707; bh=W47neQRs6KW274PsGCHaS4Pdq/oj18A8VCqxZkjWcBw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tA0Tk7jFM7neWx68+M8AfUvJJ2kOL/UcX4vbAak67lfGs6XVIUkcApZIAi+ztWpj8 xvkDlpT8ggfQFQLiDeD48ueVrHkBXAq/9yyLTefsM6Cm/k5Q027+icp+fMmItHa3w9 YZJ9xpRscDVVKNbfCFRaIE3iWLspnW5EISLQCu1Cugix9JiZCNAJ33iEp/RIZSSKHJ fqmWzU0QUV9WuRK98ZM+gD3XEREvU62iWhRu5C1xXJn6ZAShyBUPYUu7eN/B1WNkII 1NTTzWpnbxHB9LIluPJsmNZtURZIkeTwvS//7guZxHGhirlVNLm5HK9aztx2AytViK 6XyKY7AqOyCnQ== Message-ID: <00407e04-2d97-4770-97d2-399c520e38cd@kernel.org> Date: Wed, 21 Jan 2026 08:28:26 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/6] x86/CPU/AMD: Prefix messages with x86/amd To: Borislav Petkov Cc: Yazen Ghannam , Jean Delvare , linux-kernel@vger.kernel.org References: <20260121060431.432350-1-superm1@kernel.org> <20260121060431.432350-6-superm1@kernel.org> <20260121104920.GAaXCvMIrq8cQ1MPDP@fat_crate.local> Content-Language: en-US From: "Mario Limonciello (AMD) (kernel.org)" In-Reply-To: <20260121104920.GAaXCvMIrq8cQ1MPDP@fat_crate.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/21/2026 4:49 AM, Borislav Petkov wrote: > On Wed, Jan 21, 2026 at 12:04:30AM -0600, Mario Limonciello (AMD) wrote: >> To clarify which messages come from arch/x86/kernel/cpu/amd.c add >> a prefix to all messages instead of just the previous reset reason. >> >> Reviewed-by: Yazen Ghannam >> Signed-off-by: Mario Limonciello (AMD) >> --- >> v3: >> * add tag, put in it's own series >> --- >> arch/x86/kernel/cpu/amd.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c >> index bc94ff1e250ad..c19c4ee74dd1f 100644 >> --- a/arch/x86/kernel/cpu/amd.c >> +++ b/arch/x86/kernel/cpu/amd.c >> @@ -1,4 +1,6 @@ >> // SPDX-License-Identifier: GPL-2.0-only >> +#define pr_fmt(fmt) "x86/amd: " fmt > > I'm still not sure about this. There are a lot of places which you can call > "x86/amd:" - not only this one. So if anything, this prefix should be called > "x86/CPU:". > > But looking at cpu/intel.c, they have "x86/tme:" and "x86/mktme:" prefixes > there for the TME specific stuff. > > So I still don't see a clear working logic to apply to x86/cpu/ compilation > units. > > So unless there's a better idea, pls drop this for now. > > Thx. > Well so if I drop this patch, I still want to apply some sort of prefix to patch 6/6. Because otherwise you end up with an AGESA string with no context of what that actually means or goes with. Any other ideas of what to prefix that with? Maybe: pr_info("AMD BIOS: %s\n")