From: John Garry <john.g.garry@oracle.com>
To: Xingui Yang <yangxingui@huawei.com>,
yanaijie@huawei.com, jejb@linux.ibm.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, liyihang9@h-partners.com,
liuyonglong@huawei.com, kangfenglong@huawei.com
Subject: Re: [PATCH v2] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed"
Date: Tue, 2 Dec 2025 13:12:02 +0000 [thread overview]
Message-ID: <0040f262-b820-4f6f-909b-a10b5b878a3d@oracle.com> (raw)
In-Reply-To: <20251202065627.140361-1-yangxingui@huawei.com>
On 02/12/2025 06:56, Xingui Yang wrote:
> This reverts commit ab2068a6fb84751836a84c26ca72b3beb349619d.
>
> When probing the exp-attached sata device, libsas/libata will issue a hard
> reset in sas_probe_sata() -> ata_sas_async_probe(), then a broadcast event
> will be received after the disk probe fails, and this commit causes the
> probe will be re-executed on the disk, and a faulty disk may get into an
> indefinite loop of probe.
>
> Therefore, revert this commit, although it can fix some temporary issues
> with disk probe failure.
>
> Signed-off-by: Xingui Yang <yangxingui@huawei.com>
> Reviewed-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2025-12-02 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 6:56 Xingui Yang
2025-12-02 13:12 ` John Garry [this message]
2025-12-03 6:36 ` Martin K. Petersen
2025-12-09 3:21 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0040f262-b820-4f6f-909b-a10b5b878a3d@oracle.com \
--to=john.g.garry@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=kangfenglong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=liyihang9@h-partners.com \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®