From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754313AbcBVKc4 (ORCPT ); Mon, 22 Feb 2016 05:32:56 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:36445 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754170AbcBVKcz (ORCPT ); Mon, 22 Feb 2016 05:32:55 -0500 X-AuditID: cbfee61a-f79266d000003652-4e-56cae3d52cae From: Chao Yu To: Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] f2fs: fix the wrong stat count of calling gc Date: Mon, 22 Feb 2016 18:32:13 +0800 Message-id: <004701d16d5c$62e1f790$28a5e6b0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AdFtXD7LY3L2/UjvQeOa9a/1OzKCEw== Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFLMWRmVeSWpSXmKPExsVy+t9jQd2rj0+FGVzv0rJ4sn4Ws8WlRe4W l3fNYXNg9ti0qpPNY/eCz0wenzfJBTBHcdmkpOZklqUW6dslcGVs3ZFccIGjYveiJpYGxsds XYycHBICJhJP9s9lh7DFJC7cWw8U5+IQEpjFKNF3YxYzhPOKUWLJzqNMIFVsAioSyzv+g9ki QPahRZfBupkFPCQaO76zgtjCAo4Sa66/BdvAIqAqseHxP5YuRg4OXgFLiSdLo0DCvAKCEj8m 32OBaNWSWL/zOBOELS+xec1bZoiDFCR2nH3NCLFKT+Lhs5uMEDXiEhuP3GKZwAh0JcKoWUhG zUIyahaSlgWMLKsYJVILkguKk9JzDfNSy/WKE3OLS/PS9ZLzczcxgkP4mdQOxoO73A8xCnAw KvHwNrCcChNiTSwrrsw9xCjBwawkwtv2ACjEm5JYWZValB9fVJqTWnyIUZqDRUmc9/H/dWFC AumJJanZqakFqUUwWSYOTqkGxin6fvIpf75uLH+R/C/zQ8vy23823j8g6rgg4fjJt7ektl/c /3BWs7GNqq3aPb/dP2a5+Joy2ptFvksIsjC0ZcvOv8M58+G8Y1xFSzXTd9asW2rHJr724ul3 +3vv/SuUTJ4SFqWwgM1DiIc5QW+KnLd/voaRAm+NhZ7vQ/YzX6N82O1OP16+SYmlOCPRUIu5 qDgRAI872qddAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With a partition which was formated as multi segments in one section, we stated incorrectly for count of gc operation. e.g., for a partition with segs_per_sec = 4 cat /sys/kernel/debug/f2fs/status GC calls: 208 (BG: 7) - data segments : 104 (52) - node segments : 104 (24) GC called count should be (104 (data segs) + 104 (node segs)) / 4 = 52, rather than 208. Fix it. Signed-off-by: Chao Yu --- fs/f2fs/gc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 47ade35..6b2d704 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -816,7 +816,6 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, gc_type); stat_inc_seg_count(sbi, type, gc_type); - stat_inc_call_count(sbi->stat_info); f2fs_put_page(sum_page, 0); } @@ -841,6 +840,9 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, if (get_valid_blocks(sbi, start_segno++, 1) == 0) seg_freed++; } + + stat_inc_call_count(sbi->stat_info); + return seg_freed; } -- 2.7.0