From: Jason Yan <yanaijie@huawei.com>
To: Denis Efremov <efremov@linux.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: libsas: remove the exporting of sas_wait_eh
Date: Tue, 9 Jul 2019 09:58:50 +0800 [thread overview]
Message-ID: <00489583-ff52-d9b7-5e46-478aa361758e@huawei.com> (raw)
In-Reply-To: <20190708164339.14465-1-efremov@linux.com>
On 2019/7/9 0:43, Denis Efremov wrote:
> The function sas_wait_eh is declared static and marked
> EXPORT_SYMBOL, which is at best an odd combination. Because the
> function is not used outside of the drivers/scsi/libsas/sas_scsi_host.c
> file it is defined in, this commit removes the EXPORT_SYMBOL() marking.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
> ---
> drivers/scsi/libsas/sas_scsi_host.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> index ede0674d8399..5564d3f1243a 100644
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -414,7 +414,6 @@ static void sas_wait_eh(struct domain_device *dev)
> goto retry;
> }
> }
> -EXPORT_SYMBOL(sas_wait_eh);
>
> static int sas_queue_reset(struct domain_device *dev, int reset_type,
> u64 lun, int wait)
>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
next prev parent reply other threads:[~2019-07-09 1:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 16:43 Denis Efremov
2019-07-09 1:58 ` Jason Yan [this message]
2019-07-12 0:34 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00489583-ff52-d9b7-5e46-478aa361758e@huawei.com \
--to=yanaijie@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=efremov@linux.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®