mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Bowler <jbowler@acm.org>
To: "'David Vrabel'" <dvrabel@cantab.net>
Cc: "'Deepak Saxena'" <dsaxena@plexity.net>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] 2.6.14-rc3 ixp4xx_copy_from little endian/alignment
Date: Fri, 28 Oct 2005 17:16:45 -0700	[thread overview]
Message-ID: <004c01c5dc1e$0ce4fbb0$1001a8c0@kalmiopsis> (raw)
In-Reply-To: <43628B40.50902@cantab.net>

From: David Vrabel [mailto:dvrabel@cantab.net]
>It appears that the NSLU2 only has the flash on the expansion bus which 
>is why you believe it's a flash specific problem.

Which would also explain why a flash specific solution works...  I'll
try an experiment without the XOR on the address and with data coherency.

The issue here is whether that's the right answer for hypothetical other
IXP4XX LE systems which have both flash and non-flash peripherals on EXP.

Still, it doesn't much matter - NSLU2 doesn't have such devices (so far as
I know - i.e. I believe that your statement about there being nothing else
on the EXP bus is correct) and we implemented this patch for NSLU2, even
though it isn't NSLU2 specific.

>Data coherency can be set on a per 1 Mibyte page basis so all other (APB 
>and PCI) peripherals would continue to use address coherency and thus 
>would continue to function as they are now.

Ok... so I'll try to find a way to do this in the board level code, or
maybe better in the IXP4XX setup (drivers/mtd/maps/ixp4xx.c?)

It's worth considering that, so far as I can see, nothing which uses
drivers/mtd/maps/ixp4xx.c will currently work in LE unless it is already
setting data coherency on the flash addresses.  Is NSLU2 the first IXP4XX
system to run LE and to access the flash (from a running system, not from
the boot loader?)

John Bowler <jbowler@acm.org>


      reply	other threads:[~2005-10-29  1:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-28  6:09 John Bowler
2005-10-28  8:13 ` Lennert Buytenhek
2005-10-28 12:40 ` David Vrabel
2005-10-28 16:32   ` John Bowler
2005-10-28 20:34     ` David Vrabel
2005-10-29  0:16       ` John Bowler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004c01c5dc1e$0ce4fbb0$1001a8c0@kalmiopsis' \
    --to=jbowler@acm.org \
    --cc=dsaxena@plexity.net \
    --cc=dvrabel@cantab.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®