From: Alistair <alistair@alistair23.me>
To: "Linus Walleij" <linus.walleij@linaro.org>
Cc: ye.xingchen@zte.com.cn,
"Sebastian Reichel" <sebastian.reichel@collabora.com>,
sre@kernel.org, pali@kernel.org, sravanhome@gmail.com,
linux-pm@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: power_supply_show_property Kernel Oops
Date: Thu, 30 Mar 2023 18:00:43 +1000 [thread overview]
Message-ID: <004cfeda-1c40-4fce-b5d5-1ecc02a8909a@app.fastmail.com> (raw)
In-Reply-To: <CACRpkdZSJCZZEkD0V_wint+a1XKsbCQFuArFvPdFP8RSDsGLMQ@mail.gmail.com>
On Thu, 30 Mar 2023, at 12:43 AM, Linus Walleij wrote:
> On Wed, Mar 29, 2023 at 1:16 PM Alistair <alistair@alistair23.me> wrote:
>
> > [ 2.466136] string from vsnprintf+0x158/0x424
> > [ 2.470603] vsnprintf from vscnprintf+0x10/0x24
> > [ 2.475241] vscnprintf from sysfs_emit+0x50/0xac
> > [ 2.479975] sysfs_emit from power_supply_show_property+0x1d0/0x26c
> > [ 2.486269] power_supply_show_property from add_prop_uevent+0x30/0x8c
> > [ 2.492815] add_prop_uevent from power_supply_uevent+0xb4/0xe4
> > [ 2.498753] power_supply_uevent from dev_uevent+0xc4/0x21c
> > [ 2.504352] dev_uevent from kobject_uevent_env+0x1cc/0x510
> > [ 2.509953] kobject_uevent_env from power_supply_changed_work+0x7c/0xb4
> > [ 2.516675] power_supply_changed_work from process_one_work+0x1e8/0x3e8
> > [ 2.523396] process_one_work from worker_thread+0x2c/0x504
> > [ 2.528986] worker_thread from kthread+0xcc/0xec
> > [ 2.533716] kthread from ret_from_fork+0x14/0x24
> > [ 2.538443] Exception stack(0xf0dadfb0 to 0xf0dadff8)
>
> This looks like running a worker before something this worker is accessing
> has been set up.
>
> > As it's on a consumer device I don't have a way to connect a debugger. So I'm
> > a little stuck on what the problem is. The only related change I see between
> > 6.2 and 6.3-rc4 is commit a441f3b90a340e5c94df36c33fb7000193ee0aa7
> > "power: supply: use sysfs_emit() instead of sprintf() for sysfs show()", but
> > that doesn't look like it would cause this oops.
>
> Did you try reverting it?
I did after I sent this. Reverting the commit doesn't fix the issue.
Alistair
>
> Yours,
> Linus Walleij
>
prev parent reply other threads:[~2023-03-30 8:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 11:15 Alistair
2023-03-29 14:43 ` Linus Walleij
2023-03-29 22:47 ` Sebastian Reichel
2023-03-30 8:00 ` Alistair
2023-03-31 23:54 ` Sebastian Reichel
2023-03-30 8:00 ` Alistair [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=004cfeda-1c40-4fce-b5d5-1ecc02a8909a@app.fastmail.com \
--to=alistair@alistair23.me \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=sravanhome@gmail.com \
--cc=sre@kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®