From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755810AbcEaHcS (ORCPT ); Tue, 31 May 2016 03:32:18 -0400 Received: from out4133-98.mail.aliyun.com ([42.120.133.98]:49816 "EHLO out4133-98.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755315AbcEaHcP (ORCPT ); Tue, 31 May 2016 03:32:15 -0400 X-Greylist: delayed 318 seconds by postgrey-1.27 at vger.kernel.org; Tue, 31 May 2016 03:32:15 EDT X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03297;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_----4s7lUQO_1464679596; Reply-To: "Hillf Danton" From: "Hillf Danton" To: "'Aneesh Kumar K.V'" Cc: "'linux-kernel'" , References: <001701d1ba44$b9c0d560$2d428020$@alibaba-inc.com> <001901d1ba4a$514eccc0$f3ec6640$@alibaba-inc.com> <87mvn71rwc.fsf@skywalker.in.ibm.com> <002b01d1baef$e6246530$b26d2f90$@alibaba-inc.com> <87h9de201i.fsf@skywalker.in.ibm.com> In-Reply-To: <87h9de201i.fsf@skywalker.in.ibm.com> Subject: Re: [RFC PATCH 2/4] mm: Change the interface for __tlb_remove_page Date: Tue, 31 May 2016 15:26:36 +0800 Message-ID: <004f01d1bb0d$c4537db0$4cfa7910$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQHCUcxPez5cCjoFblCkJXAnnBBTsQHvpvdgApv0A3QCAr27NQHuILtsn62T8uA= Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Do you want to update ->addr here? > > > > I don't get that question. We wanted to track the alst adjusted addr in > tlb->addr because when we do a tlb_flush_mmu_tlbonly() we does a > __tlb_reset_range(), which clears tlb->start and tlb->end. Now we need > to update the range again with the last adjusted addr before we can call > __tlb_remove_page(). Look for VM_BUG_ON(!tlb->end); in > __tlb_remove_page(). > Got, thanks. Hillf