From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 229B7C388F9 for ; Thu, 22 Oct 2020 16:58:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F74A2463F for ; Thu, 22 Oct 2020 16:58:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2898354AbgJVQ57 (ORCPT ); Thu, 22 Oct 2020 12:57:59 -0400 Received: from shelob.surriel.com ([96.67.55.147]:34926 "EHLO shelob.surriel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2898332AbgJVQ57 (ORCPT ); Thu, 22 Oct 2020 12:57:59 -0400 Received: from imladris.surriel.com ([96.67.55.152]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kVduW-0001tE-8q; Thu, 22 Oct 2020 12:57:56 -0400 Message-ID: <004fe66ee1d111ec006dd065b9bed5fdcfdaad01.camel@surriel.com> Subject: Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat From: Rik van Riel To: Johannes Weiner , Andrew Morton Cc: Michal Hocko , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Date: Thu, 22 Oct 2020 12:57:55 -0400 In-Reply-To: References: <20201022151844.489337-1-hannes@cmpxchg.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-q/yjJ9zoR2cgocIosU9b" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Sender: riel@shelob.surriel.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-q/yjJ9zoR2cgocIosU9b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2020-10-22 at 12:49 -0400, Rik van Riel wrote: > On Thu, 2020-10-22 at 11:18 -0400, Johannes Weiner wrote: >=20 > > index e80aa9d2db68..334ce608735c 100644 > > --- a/mm/filemap.c > > +++ b/mm/filemap.c > > @@ -204,9 +204,9 @@ static void unaccount_page_cache_page(struct > > address_space *mapping, > > if (PageSwapBacked(page)) { > > __mod_lruvec_page_state(page, NR_SHMEM, -nr); > > if (PageTransHuge(page)) > > - __dec_node_page_state(page, NR_SHMEM_THPS); > > + __dec_lruvec_page_state(page, NR_SHMEM_THPS); > > } else if (PageTransHuge(page)) { > > - __dec_node_page_state(page, NR_FILE_THPS); > > + __dec_lruvec_page_state(page, NR_FILE_THPS); > > filemap_nr_thps_dec(mapping); > > } >=20 > This may be a dumb question, but does that mean the > NR_FILE_THPS number will no longer be visible in > /proc/vmstat or is there some magic I overlooked in > a cursory look of the code? Never mind, I found it a few levels deep in __dec_lruvec_page_state. Reviewed-by: Rik van Riel --=20 All Rights Reversed. --=-q/yjJ9zoR2cgocIosU9b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAl+RuhQACgkQznnekoTE 3oNrzwf9GSWmH30yYW4VoJhqcAiuVzpHRu/K7HGUTezlWzZgMV+ef6NYaUk0NItK sIgNpwCkeBZXg99ZG6y7o/yBiMLB7LR9E5PdREv+7CQrgZ8dvTbu0OhsmhOvo8TL +ufRBaAt4aK1Melt27dbnooHH43PVqRODDI9nkp4NU/aSIGami/KCAIGf3JfMEyR mK7THczWyFCknk1LWfPIbhYb3cneiwM62w07Xn3Fs4ord5612IvbW3iULFEMQwAO FUQ8DZycLWEIJL9DDa/eYeNH9c0cq0tzdiRBsaESVnT4q/I0gapNN4eLora3VCzi xqEBWQ22PQDOuUdJ0Lc7fyrhnplMWA== =/3Jx -----END PGP SIGNATURE----- --=-q/yjJ9zoR2cgocIosU9b--