From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D5B4C433EF for ; Mon, 20 Jun 2022 07:12:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239113AbiFTHL7 (ORCPT ); Mon, 20 Jun 2022 03:11:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239105AbiFTHL5 (ORCPT ); Mon, 20 Jun 2022 03:11:57 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98392DFED; Mon, 20 Jun 2022 00:11:52 -0700 (PDT) X-UUID: 9cb3b879b5de4b34968868a1cfa249fe-20220620 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:4da5d0e4-b930-4271-bf28-fa92538deb46,OB:0,LO B:0,IP:0,URL:25,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,AC TION:release,TS:70 X-CID-INFO: VERSION:1.1.6,REQID:4da5d0e4-b930-4271-bf28-fa92538deb46,OB:0,LOB: 0,IP:0,URL:25,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Spam_GS981B3D,AC TION:quarantine,TS:70 X-CID-META: VersionHash:b14ad71,CLOUDID:a960fbe9-f7af-4e69-92ee-0fd74a0c286c,C OID:1f7819935380,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: 9cb3b879b5de4b34968868a1cfa249fe-20220620 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 823410917; Mon, 20 Jun 2022 15:11:46 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Mon, 20 Jun 2022 15:11:45 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 20 Jun 2022 15:11:44 +0800 Message-ID: <0050627cdd64c02bb84f4694fc8994a5cb27d0f2.camel@mediatek.com> Subject: Re: [PATCH v6 1/4] dt-bindings: nvmem: convert mtk-efuse.txt to YAML schema From: Chunfeng Yun To: Srinivas Kandagatla , Matthias Brugger CC: Rob Herring , Krzysztof Kozlowski , , , , , Allen-KH Cheng , Eddie Hung , Krzysztof Kozlowski , Rob Herring Date: Mon, 20 Jun 2022 15:11:44 +0800 In-Reply-To: <46ec62eb-00da-defb-219f-92121fd35d7e@linaro.org> References: <20220617093132.22578-1-chunfeng.yun@mediatek.com> <46ec62eb-00da-defb-219f-92121fd35d7e@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, On Fri, 2022-06-17 at 12:41 -0700, Srinivas Kandagatla wrote: > > On 17/06/2022 02:31, Chunfeng Yun wrote: > > Convert mtk-efuse.txt to YAML schema mediatek,efuse.yaml > > > > Reviewed-by: Krzysztof Kozlowski > > Reviewed-by: Rob Herring > > Signed-off-by: Chunfeng Yun > > --- > > Applied 1/4 and 2/4, dts patches need to go via SoC maintainer. Could you please help to pick up 3/4, 4/4? thanks > > > thanks, > -srini > > > > v6: no changes, based on kernel 5.19-rc1 > > > > v5: > > sync with the series: > > https://patchwork.kernel.org/project/linux-mediatek/list/?series=640196 > > 1. change title suggested by Krzysztof; > > 2. No need drop 'reviewed-by Rob' suggested by Krzysztof > > 3. add maintainer Lala who maintain efuse driver now; > > > > v4: fix duplicated unit-address in example; > > drop reviewed-by Rob, due to changes; > > > > v3: add reviewed-by Rob > > > > v2: > > 1. remove description of subnodes which is covered by > > nvmem.yaml > > suggested by Rob > > 2. change the example which is commoner than mt8173's > > --- > > .../bindings/nvmem/mediatek,efuse.yaml | 87 > > +++++++++++++++++++ > > .../devicetree/bindings/nvmem/mtk-efuse.txt | 43 --------- > > 2 files changed, 87 insertions(+), 43 deletions(-) > > create mode 100644 > > Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > > delete mode 100644 Documentation/devicetree/bindings/nvmem/mtk- > > efuse.txt > > > > diff --git > > a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > > b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > > new file mode 100644 > > index 000000000000..f6e01ddb7499 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > > @@ -0,0 +1,87 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/nvmem/mediatek,efuse.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek efuse > > + > > +description: | > > + MediaTek's efuse is used for storing calibration data, it can be > > accessed > > + on ARM devices usiong I/O mapped memory. > > + > > +maintainers: > > + - Andrew-CT Chen > > + - Lala Lin > > + > > +allOf: > > + - $ref: "nvmem.yaml#" > > + > > +properties: > > + $nodename: > > + pattern: "^efuse@[0-9a-f]+$" > > + > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - mediatek,mt7622-efuse > > + - mediatek,mt7623-efuse > > + - mediatek,mt8173-efuse > > + - mediatek,mt8192-efuse > > + - mediatek,mt8195-efuse > > + - mediatek,mt8516-efuse > > + - const: mediatek,efuse > > + - const: mediatek,mt8173-efuse > > + deprecated: true > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + efuse@11c10000 { > > + compatible = "mediatek,mt8195-efuse", "mediatek,efuse"; > > + reg = <0x11c10000 0x1000>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + u3_tx_imp_p0: usb3-tx-imp@184,1 { > > + reg = <0x184 0x1>; > > + bits = <0 5>; > > + }; > > + u3_rx_imp_p0: usb3-rx-imp@184,2 { > > + reg = <0x184 0x2>; > > + bits = <5 5>; > > + }; > > + u3_intr_p0: usb3-intr@185 { > > + reg = <0x185 0x1>; > > + bits = <2 6>; > > + }; > > + comb_tx_imp_p1: usb3-tx-imp@186,1 { > > + reg = <0x186 0x1>; > > + bits = <0 5>; > > + }; > > + comb_rx_imp_p1: usb3-rx-imp@186,2 { > > + reg = <0x186 0x2>; > > + bits = <5 5>; > > + }; > > + comb_intr_p1: usb3-intr@187 { > > + reg = <0x187 0x1>; > > + bits = <2 6>; > > + }; > > + u2_intr_p0: usb2-intr-p0@188,1 { > > + reg = <0x188 0x1>; > > + bits = <0 5>; > > + }; > > + u2_intr_p1: usb2-intr-p1@188,2 { > > + reg = <0x188 0x2>; > > + bits = <5 5>; > > + }; > > + }; > > diff --git a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt > > b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt > > deleted file mode 100644 > > index 39d529599444..000000000000 > > --- a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt > > +++ /dev/null > > @@ -1,43 +0,0 @@ > > -= Mediatek MTK-EFUSE device tree bindings = > > - > > -This binding is intended to represent MTK-EFUSE which is found in > > most Mediatek SOCs. > > - > > -Required properties: > > -- compatible: should be > > - "mediatek,mt7622-efuse", "mediatek,efuse": for MT7622 > > - "mediatek,mt7623-efuse", "mediatek,efuse": for MT7623 > > - "mediatek,mt8173-efuse" or "mediatek,efuse": for MT8173 > > - "mediatek,mt8192-efuse", "mediatek,efuse": for MT8192 > > - "mediatek,mt8195-efuse", "mediatek,efuse": for MT8195 > > - "mediatek,mt8516-efuse", "mediatek,efuse": for MT8516 > > -- reg: Should contain registers location and length > > -- bits: contain the bits range by offset and size > > - > > -= Data cells = > > -Are child nodes of MTK-EFUSE, bindings of which as described in > > -bindings/nvmem/nvmem.txt > > - > > -Example: > > - > > - efuse: efuse@10206000 { > > - compatible = "mediatek,mt8173-efuse"; > > - reg = <0 0x10206000 0 0x1000>; > > - #address-cells = <1>; > > - #size-cells = <1>; > > - > > - /* Data cells */ > > - thermal_calibration: calib@528 { > > - reg = <0x528 0xc>; > > - }; > > - }; > > - > > -= Data consumers = > > -Are device nodes which consume nvmem data cells. > > - > > -For example: > > - > > - thermal { > > - ... > > - nvmem-cells = <&thermal_calibration>; > > - nvmem-cell-names = "calibration"; > > - };