From: Tim Chen <tim.c.chen@linux.intel.com>
To: Hui Su <sh_def@163.com>, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Cc: Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Valentin Schneider <vschneid@redhat.com>,
John Stultz <jstultz@google.com>, Chen Yu <yu.c.chen@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] sched/cache: Drive cache task tick from execution context
Date: Thu, 03 Sep 2026 10:23:05 -0700 [thread overview]
Message-ID: <0051f02bd8d6f69fa7018b34386ccc22034dffde.camel@linux.intel.com> (raw)
In-Reply-To: <20260903041154.2479761-3-sh_def@163.com>
On Thu, 2026-09-03 at 12:11 +0800, Hui Su wrote:
>
[snip]
> void init_sched_mm(struct task_struct *p) { }
>
> -static void task_tick_cache(struct rq *rq, struct task_struct *p) { }
> +void task_tick_cache(struct rq *rq, struct task_struct *p) { }
>
> static inline int get_pref_llc(struct task_struct *p,
> struct mm_struct *mm)
> @@ -15042,8 +15042,6 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
> if (queued)
> return;
>
> - task_tick_cache(rq, curr);
> -
May be worth adding a comment here. Say you consolidate the
exec context stuff to a new sched_tick_exec_ctx() helper.
You can say something like the following here to help future
reader of this code.
+ /*
+ * Note: misfit, overutilized and core scheduling state describe the
+ * entity the load balancer would move, i.e. the scheduling context,
+ * and therefore stay with @curr rather than with rq->curr. See
+ * sched_tick_exec_ctx() for the execution context counterpart.
+ */
> update_misfit_status(curr, rq);
> check_update_overutilized_status(task_rq(curr));
Tim
next prev parent reply other threads:[~2026-09-03 17:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 4:11 [PATCH v2 0/2] sched: Fix execution-context tick handling under proxy execution Hui Su
2026-09-03 4:11 ` [PATCH v2 1/2] sched/numa: Drive NUMA task tick from execution context Hui Su
2026-09-03 12:41 ` Chen, Yu C
2026-09-03 21:30 ` Tim Chen
2026-09-04 5:16 ` Hui Su
2026-09-04 14:10 ` Hui Su
2026-09-04 20:15 ` Tim Chen
2026-09-05 13:58 ` Hui Su
2026-09-04 16:10 ` Chen Yu
2026-09-04 20:24 ` Tim Chen
2026-09-03 4:11 ` [PATCH v2 2/2] sched/cache: Drive cache " Hui Su
2026-09-03 4:37 ` K Prateek Nayak
2026-09-03 4:51 ` Hui Su
2026-09-03 17:23 ` Tim Chen [this message]
2026-09-04 4:03 ` Hui Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0051f02bd8d6f69fa7018b34386ccc22034dffde.camel@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sh_def@163.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®