mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: "'Sachin Kamat'" <sachin.kamat@linaro.org>,
	"'Kishon Vijay Abraham I'" <kishon@ti.com>
Cc: linux-kernel@vger.kernel.org, "'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO
Date: Mon, 02 Jun 2014 11:26:32 +0900	[thread overview]
Message-ID: <005201cf7e0a$11d1d250$357576f0$%han@samsung.com> (raw)
In-Reply-To: <1401345049-14779-1-git-send-email-sachin.kamat@linaro.org>

On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
> 
> PTR_ERR_OR_ZERO simplifies the code.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Jingoo Han <jg1.han@samsung.com>

Acked-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
>  drivers/phy/phy-exynos-dp-video.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
> index 0786fef842e7..098f822a2fa4 100644
> --- a/drivers/phy/phy-exynos-dp-video.c
> +++ b/drivers/phy/phy-exynos-dp-video.c
> @@ -9,6 +9,7 @@
>   * published by the Free Software Foundation.
>   */
> 
> +#include <linux/err.h>
>  #include <linux/io.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
>  	phy_set_drvdata(phy, state);
> 
>  	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> -	if (IS_ERR(phy_provider))
> -		return PTR_ERR(phy_provider);
> 
> -	return 0;
> +	return PTR_ERR_OR_ZERO(phy_provider);
>  }
> 
>  static const struct of_device_id exynos_dp_video_phy_of_match[] = {
> --
> 1.7.9.5


  parent reply	other threads:[~2014-06-02  2:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29  6:30 Sachin Kamat
2014-05-29  6:30 ` [PATCH 2/3] phy: exynos-mipi-video: " Sachin Kamat
2014-05-30 12:58   ` Sylwester Nawrocki
2014-05-29  6:30 ` [PATCH 3/3] phy: sun4i-usb: " Sachin Kamat
2014-05-30  8:13   ` Hans de Goede
2014-06-02  2:26 ` Jingoo Han [this message]
2014-06-12  9:49   ` [PATCH 1/3] phy: exynos-dp-video: " Sachin Kamat
2014-06-12  9:57     ` Kishon Vijay Abraham I
2014-06-12  9:59       ` Sachin Kamat
2014-07-02  8:44       ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='005201cf7e0a$11d1d250$357576f0$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®