mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: Joe Perches <joe@perches.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] staging: rtl8723bs: fix indentation
Date: Wed, 11 Jul 2018 15:57:07 +0200	[thread overview]
Message-ID: <005bbcfc-402d-db85-8f5a-1b64cfe6b612@gmail.com> (raw)
In-Reply-To: <b7468cdd-1555-ef61-b475-3d4677aa423a@gmail.com>

On 07/08/18 19:36, Michael Straube wrote:
> On 07/08/18 18:46, Joe Perches wrote:
>> On Sun, 2018-07-08 at 12:38 +0200, Michael Straube wrote:
>>
>> uint rtw_is_cckratesonly_included(u8 *rate)
>> {
>>     while (*rate) {
>>         u8 r = *rate & 0x7f;
>>
>>         if (r != 2 && r != 4 && r != 11 && r != 22)
>>             return false;
>>         rate++;
>>     }
>>
>>     return true;
>> }
>>
> 
> The patch has been added to staging-testing already.
> I will send patches with your suggestions the next days.

Would it be preferred to declare the variable at the functions beginning,
or doesn't it matter regarding coding style?

uint rtw_is_cckratesonly_included(u8 *rate)
{
         u8 r;

         while (*rate) {
                 r = *rate & 0x7f;
         ...

Best,
Michael


  reply	other threads:[~2018-07-11 13:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-08 10:38 [PATCH 1/6] staging: rtl8723bs: replace while with shorter for loop Michael Straube
2018-07-08 10:38 ` [PATCH 2/6] staging: rtl8723bs: replace tab with space Michael Straube
2018-07-08 10:38 ` [PATCH 3/6] staging: rtl8723bs: fix indentation Michael Straube
2018-07-08 16:46   ` Joe Perches
2018-07-08 17:36     ` Michael Straube
2018-07-11 13:57       ` Michael Straube [this message]
2018-07-11 16:03         ` Joe Perches
2018-07-11 19:17           ` Michael Straube
2018-07-08 10:38 ` [PATCH 4/6] staging: rtl8723bs: remove blank lines Michael Straube
2018-07-08 10:38 ` [PATCH 5/6] staging: rtl8723bs: add missing " Michael Straube
2018-07-08 10:38 ` [PATCH 6/6] staging: rtl8723bs: remove braces from single if statement Michael Straube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=005bbcfc-402d-db85-8f5a-1b64cfe6b612@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome