From: Chao Yu <chao2.yu@samsung.com>
To: "'Jaegeuk Kim'" <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: RE: [f2fs-dev] [PATCH 2/3] f2fs: introduce FITRIM in f2fs_ioctl
Date: Tue, 30 Sep 2014 14:01:58 +0800 [thread overview]
Message-ID: <006001cfdc74$178dcdc0$46a96940$@samsung.com> (raw)
In-Reply-To: <1411447990-37919-2-git-send-email-jaegeuk@kernel.org>
> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Tuesday, September 23, 2014 12:53 PM
> To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Cc: Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH 2/3] f2fs: introduce FITRIM in f2fs_ioctl
>
> This patch introduces FITRIM in f2fs_ioctl.
> In this case, f2fs will issue small discards and prefree discards as many as
> possible for the given area.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Looks good!
Reviewed-by: Chao Yu <chao2.yu@samsung.com>
> +
> /* zero block will be discarded through the prefree list */
> if (!se->valid_blocks || se->valid_blocks == max_blocks)
> return;
>
> + dmap = kzalloc(SIT_VBLOCK_MAP_SIZE, GFP_KERNEL);
We can afford 64 bytes allocation in stack, how about altering dmap to a local
array to reduce memory pressure at that moment and avoid delay of allocation?
> + if (!dmap)
> + return;
> +
next prev parent reply other threads:[~2014-09-30 6:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 4:53 [PATCH 1/3] f2fs: introduce cp_control structure Jaegeuk Kim
2014-09-23 4:53 ` [PATCH 2/3] f2fs: introduce FITRIM in f2fs_ioctl Jaegeuk Kim
2014-09-30 6:01 ` Chao Yu [this message]
2014-10-01 15:07 ` [f2fs-dev] " Jaegeuk Kim
2014-09-23 4:53 ` [PATCH 3/3] f2fs: refactor flush_nat_entries to remove costly reorganizing ops Jaegeuk Kim
2014-09-30 6:04 ` [f2fs-dev] " Chao Yu
2014-10-01 15:06 ` Jaegeuk Kim
2014-10-11 13:11 ` Sasha Levin
2014-09-30 6:01 ` [f2fs-dev] [PATCH 1/3] f2fs: introduce cp_control structure Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006001cfdc74$178dcdc0$46a96940$@samsung.com' \
--to=chao2.yu@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome