RE: [PATCH v3] regulators: add support max8952 regulator

[Kukjin Kim <kgene.kim@samsung.com>]

Kukjin Kim wrote:
> 
> Kyungmin Park wrote:
> >
> > Do you check the DVS feature?
> > It can support the DVS by GPIOs and platform can set the each voltages
at
> > each mode.
> >
> Ok...I agree about the feature's necessity that you said.
> 
> However, we don't need separate driver which has same/similar
functionality.
> So...would be better that could implement it in max8649...
> 
> Could you please do it based on this?...in fact, can't test it on SMDK.
> 
Hmm...
Kyungmin, if you have no time to do it, my team will do it.

Is it ok?

> Thanks.
> 
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> 
> > As quick review of max8649. It can't support it.
> >
> > Thank you,
> > Kyungmin Park
> >
> > -----Original Message-----
> > From: Kukjin Kim [mailto:kgene.kim@samsung.com]
> > Sent: Wednesday, September 08, 2010 8:26 AM
> > To: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > linux-samsung-soc@vger.kernel.org
> > Cc: lrg@slimlogic.co.uk; Changhwan Youn; Kukjin Kim; MyungJoo Ham;
> Kyungmin
> > Park
> > Subject: [PATCH v3] regulators: add support max8952 regulator
> >
> > From: Changhwan Youn <chaos.youn@samsung.com>
> >
> > The operation of max8952 is almost similar to max8649 except the output
> > voltage range. This patch adds support the max8952 regulator using
> > current max8649 implementation. And removes separate max8952.[ch] files
> > since the functionality is now merged into this driver.
> >
> > Signed-off-by: Changhwan Youn <chaos.youn@samsung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> > Cc: Kyungmin Park <kyungmin.park@samsung.com>
> > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> > ---
> > Following is as per Mark Brown's suggestion.
> > Changes since v2:
> > - Removed separate max8952.[ch] files
> >
> > Changes since v1:
> > - Added returning fail when detected wrong ID
> > - Added matching the ID from the chip in case the user got things wrong
> > - Added enum chip ID instead of 0, 1
> >
> (snip)