mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: "'Grant Likely'" <grant.likely@secretlab.ca>
Cc: "'Linus Walleij'" <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org,
	"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH 3/6] gpio: max7301: use devm_kzalloc()
Date: Fri, 15 Mar 2013 18:15:06 +0900	[thread overview]
Message-ID: <006401ce215d$95c565a0$c15030e0$%han@samsung.com> (raw)
In-Reply-To: <006201ce215d$6f133d10$4d39b730$%han@samsung.com>

Use devm_kzalloc() to make cleanup paths simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/gpio/gpio-max7301.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-max7301.c b/drivers/gpio/gpio-max7301.c
index c6c535c..6e1c984 100644
--- a/drivers/gpio/gpio-max7301.c
+++ b/drivers/gpio/gpio-max7301.c
@@ -61,7 +61,7 @@ static int max7301_probe(struct spi_device *spi)
 	if (ret < 0)
 		return ret;
 
-	ts = kzalloc(sizeof(struct max7301), GFP_KERNEL);
+	ts = devm_kzalloc(&spi->dev, sizeof(struct max7301), GFP_KERNEL);
 	if (!ts)
 		return -ENOMEM;
 
@@ -70,8 +70,6 @@ static int max7301_probe(struct spi_device *spi)
 	ts->dev = &spi->dev;
 
 	ret = __max730x_probe(ts);
-	if (ret)
-		kfree(ts);
 	return ret;
 }
 
-- 
1.7.2.5



  parent reply	other threads:[~2013-03-15  9:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15  9:14 [PATCH 1/6] gpio: adp5520: " Jingoo Han
2013-03-15  9:14 ` [PATCH 2/6] gpio: max7300: " Jingoo Han
2013-03-27  8:47   ` Linus Walleij
2013-03-15  9:15 ` Jingoo Han [this message]
2013-03-27  8:48   ` [PATCH 3/6] gpio: max7301: " Linus Walleij
2013-03-15  9:15 ` [PATCH 4/6] gpio: max732x: " Jingoo Han
2013-03-27  8:49   ` Linus Walleij
2013-03-15  9:15 ` [PATCH 5/6] gpio: mc33880: " Jingoo Han
2013-03-27  8:50   ` Linus Walleij
2013-03-15  9:16 ` [PATCH 6/6] gpio: pcf857x: " Jingoo Han
2013-03-27  8:52   ` Linus Walleij
2013-03-27  8:46 ` [PATCH 1/6] gpio: adp5520: " Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='006401ce215d$95c565a0$c15030e0$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®