mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Anton Tikhomirov <av.tikhomirov@samsung.com>
To: "'Anton Tikhomirov'" <av.tikhomirov@samsung.com>,
	"'Kishon Vijay Abraham I'" <kishon@ti.com>,
	"'Kamil Debski'" <k.debski@samsung.com>,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org
Cc: kyungmin.park@samsung.com, t.figa@samsung.com,
	s.nawrocki@samsung.com, m.szyprowski@samsung.com,
	gautam.vivek@samsung.com, mat.krawczuk@gmail.com,
	yulgon.kim@samsung.com, p.paneri@samsung.com,
	jg1.han@samsung.com, galak@codeaurora.org,
	matt.porter@linaro.org, tjakobi@math.uni-bielefeld.de,
	stern@rowland.harvard.edu, sander@humilis.net
Subject: RE: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver
Date: Thu, 06 Mar 2014 18:19:39 +0900	[thread overview]
Message-ID: <006501cf391d$335fb9a0$9a1f2ce0$%tikhomirov@samsung.com> (raw)
In-Reply-To: <006301cf391a$c99c7280$5cd55780$%tikhomirov@samsung.com>

Hi,

> Subject: RE: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver
> 
> Hi,
> 
> > Subject: Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver
> >
> > Hi,
> >
> > On Thursday 06 March 2014 02:22 PM, Anton Tikhomirov wrote:
> > > Hello,
> > >
> > >> Subject: Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver
> > >>
> > >>
> > >>
> > >> On Thursday 06 March 2014 01:56 PM, Anton Tikhomirov wrote:
> > >>> Hi Kamil,
> > >>>
> > >>> ...
> > >>>
> > >>>> +| 3. Supporting SoCs
> > >>>> ++--------------------
> > >>>> +
> > >>>> +To support a new SoC a new file should be added to the
> > drivers/phy
> > >>>> +directory. Each SoC's configuration is stored in an instance of
> > the
> > >>>> +struct samsung_usb2_phy_config.
> > >>>> +
> > >>>> +struct samsung_usb2_phy_config {
> > >>>> +	const struct samsung_usb2_common_phy *phys;
> > >>>> +	unsigned int num_phys;
> > >>>> +	bool has_mode_switch;
> > >>>
> > >>> You missed rate_to_clk here.
> > >>>
> > >>>> +};
> > >>>> +
> > >>>
> > >>> ...
> > >>>
> > >>>> diff --git a/drivers/phy/phy-samsung-usb2.c b/drivers/phy/phy-
> > >> samsung-
> > >>>> usb2.c
> > >>>> new file mode 100644
> > >>>> index 0000000..c3b7719
> > >>>> --- /dev/null
> > >>>> +++ b/drivers/phy/phy-samsung-usb2.c
> > >>>> @@ -0,0 +1,222 @@
> > >>>> +/*
> > >>>> + * Samsung SoC USB 1.1/2.0 PHY driver
> > >>>> + *
> > >>>> + * Copyright (C) 2013 Samsung Electronics Co., Ltd.
> > >>>> + * Author: Kamil Debski <k.debski@samsung.com>
> > >>>> + *
> > >>>> + * This program is free software; you can redistribute it
> and/or
> > >>>> modify
> > >>>> + * it under the terms of the GNU General Public License version
> 2
> > >> as
> > >>>> + * published by the Free Software Foundation.
> > >>>> + */
> > >>>> +
> > >>>> +#include <linux/clk.h>
> > >>>> +#include <linux/mfd/syscon.h>
> > >>>> +#include <linux/module.h>
> > >>>> +#include <linux/of.h>
> > >>>> +#include <linux/of_address.h>
> > >>>> +#include <linux/phy/phy.h>
> > >>>> +#include <linux/platform_device.h>
> > >>>> +#include <linux/spinlock.h>
> > >>>> +#include "phy-samsung-usb2.h"
> > >>>> +
> > >>>> +static int samsung_usb2_phy_power_on(struct phy *phy)
> > >>>> +{
> > >>>> +	struct samsung_usb2_phy_instance *inst =
> > phy_get_drvdata(phy);
> > >>>> +	struct samsung_usb2_phy_driver *drv = inst->drv;
> > >>>> +	int ret;
> > >>>> +
> > >>>> +	dev_dbg(drv->dev, "Request to power_on \"%s\" usb phy\n",
> > >>>> +		inst->cfg->label);
> > >>>> +	ret = clk_prepare_enable(drv->clk);
> > >>>
> > >>> clk_prepare_enable() can sleep, and therefore doesn't allow
> > >>> samusng_usb2_phy_power_on() to be used in atomic context
> > >>> (e.g. inside spin_lock-ed area), what sometimes may be desirable.
> > >>> What about to prepare clock in probe, and just enable it here
> > >>> (note: clk_enable() doesn't sleep).
> > >>
> > >> The PHY power-on callback is anyway called with mutex held, so I
> > guess
> > >> it's fine to have clk_prepare_enable() here.
> > >
> > > If we rely totally on generic PHY functions such as phy_power_on()
> > > and friends, why do we need to use locking in callbacks at all.
> >
> > Didn't get you.. We don't want to invoke power_on when init is
> getting
> > executed or you don't want power on or power off to get executed
> > simultaneously right? So we need to protect it.
> 
> I mean callbacks such as samsung_usb2_phy_power_on() which uses
> spin_lock.
> It's already protected by mutex in phy_power_on().

Well... phy_power_on() uses mutex to protect power_on() callback.
power_on() is samsung_usb2_phy_power_on() in our case.
samsung_usb2_phy_power_on() uses spinlock.
My question is why do we need to use spinlock _inside_ callback
if it is already protected by mutex.




  reply	other threads:[~2014-03-06  9:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 15:28 [PATCH v9 0/4] " Kamil Debski
2014-03-05 15:28 ` [PATCH v9 1/4] phy: core: Add an exported of_phy_get function Kamil Debski
2014-03-05 16:03   ` Tomasz Figa
2014-03-05 15:28 ` [PATCH v9 2/4] phy: core: Add devm_of_phy_get to phy-core Kamil Debski
2014-03-05 16:04   ` Tomasz Figa
2014-03-05 15:28 ` [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver Kamil Debski
2014-03-05 16:04   ` Tomasz Figa
2014-03-06  8:26   ` Anton Tikhomirov
2014-03-06  8:30     ` Kishon Vijay Abraham I
2014-03-06  8:52       ` Anton Tikhomirov
2014-03-06  8:56         ` Kishon Vijay Abraham I
2014-03-06  9:02           ` Anton Tikhomirov
2014-03-06  9:19             ` Anton Tikhomirov [this message]
2014-03-06  9:27               ` Kishon Vijay Abraham I
2014-03-07  5:16                 ` Anton Tikhomirov
2014-03-06 10:24     ` Kamil Debski
2014-03-06 10:44       ` Kishon Vijay Abraham I
2014-03-05 15:28 ` [PATCH v9 4/4] phy: Add Exynos 5250 support to the " Kamil Debski
2014-03-05 23:08 ` [PATCH v9 0/4] phy: Add new " Tobias Jakobi
2014-03-06 10:25   ` Kamil Debski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='006501cf391d$335fb9a0$9a1f2ce0$%tikhomirov@samsung.com' \
    --to=av.tikhomirov@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gautam.vivek@samsung.com \
    --cc=jg1.han@samsung.com \
    --cc=k.debski@samsung.com \
    --cc=kishon@ti.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mat.krawczuk@gmail.com \
    --cc=matt.porter@linaro.org \
    --cc=p.paneri@samsung.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sander@humilis.net \
    --cc=stern@rowland.harvard.edu \
    --cc=t.figa@samsung.com \
    --cc=tjakobi@math.uni-bielefeld.de \
    --cc=yulgon.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®