From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 387ABC4332F for ; Mon, 14 Mar 2022 18:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243920AbiCNSgW (ORCPT ); Mon, 14 Mar 2022 14:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243905AbiCNSgS (ORCPT ); Mon, 14 Mar 2022 14:36:18 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C35493EA9D; Mon, 14 Mar 2022 11:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647282907; x=1678818907; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=uGjJrAPj26i3gB3nwOfJJbnYbtIQpt9SBZFoTdHol64=; b=bj3lfT0iVvrBdTspiXL76aWJ6duyO0exReN8EWMzMaz7byw3JnyLa4Lm tfxRBMG42n+jd7OKkJbHoVtN27VL3XMToWF9XH0Zzy+HWQMtNqYqzaUXS inQS8p7Jth0kqDrRPbjpnrMBp95OPkxqI1xiif4IfPlXBQxFr03l4epWs NOA9dLr5thOxhvZ8xZKDtBB9LqnelFbT8peMkU4Rx8OOqJMy5j9C5Vsx0 WR9upS/99yONGjd5TzCFt0rr+iN+0eL98CTdBfG6BlG+ghsjgDg9TXh0G eLSTkAUPIHsGBV+q3J3alPKnAlYcd6Ur6CBiNh/tCc8k0UinHDlucF5Qs w==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="256067006" X-IronPort-AV: E=Sophos;i="5.90,181,1643702400"; d="scan'208";a="256067006" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2022 11:35:07 -0700 X-IronPort-AV: E=Sophos;i="5.90,181,1643702400"; d="scan'208";a="713849153" Received: from spandruv-desk.jf.intel.com ([10.54.75.8]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2022 11:35:07 -0700 Message-ID: <00654dae7f6b95533a66055ea125ddb640efd7fd.camel@linux.intel.com> Subject: Re: [PATCH] thermal: int340x: Increase bitmap size From: srinivas pandruvada To: David Laight , "rafael@kernel.org" , "daniel.lezcano@linaro.org" , "amitk@kernel.org" , "rui.zhang@intel.com" Cc: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "matthewgarrett@google.com" , "stable@vger.kernel.org" Date: Mon, 14 Mar 2022 11:35:07 -0700 In-Reply-To: References: <20220314145017.928550-1-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-03-14 at 15:28 +0000, David Laight wrote: > From: Srinivas Pandruvada > > Sent: 14 March 2022 14:50 > > > > The number of policies are 10, so can't be supported by the bitmap > > size > > of u8. Even though there are no platfoms with these many policies, > > but > > as correctness increase to u16. > > You might as well just use 'unsigned int'. > May generate better code and there is still padding > in the structure. Correct. I can update the patch. Thanks, Srinivas > >         David > > > > > Signed-off-by: Srinivas Pandruvada < > > srinivas.pandruvada@linux.intel.com> > > Fixes: 16fc8eca1975 ("thermal/int340x_thermal: Add additional > > UUIDs") > > Cc: stable@vger.kernel.org > > --- > >  drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > > b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > > index 72acb1f61849..c2d3df302214 100644 > > --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > > +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > > @@ -53,7 +53,7 @@ struct int3400_thermal_priv { > >         struct art *arts; > >         int trt_count; > >         struct trt *trts; > > -       u8 uuid_bitmap; > > +       u16 uuid_bitmap; > >         int rel_misc_dev_res; > >         int current_uuid_index; > >         char *data_vault; > > -- > > 2.31.1 > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, > MK1 1PT, UK > Registration No: 1397386 (Wales) >