mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hal Feng <hal.feng@starfivetech.com>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor@kernel.org>,
	Walker Chen <walker.chen@starfivetech.com>,
	Xingyu Wu <xingyu.wu@starfivetech.com>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/5] ASoC: dt-bindings: Add StarFive JH7110 dummy PWM-DAC transmitter
Date: Mon, 26 Jun 2023 17:34:56 +0200	[thread overview]
Message-ID: <006ddacd-0496-70d1-3310-99b16706de84@linaro.org> (raw)
In-Reply-To: <20230626110909.38718-2-hal.feng@starfivetech.com>

On 26/06/2023 13:09, Hal Feng wrote:
> Add bindings for StarFive JH7110 dummy PWM-DAC transmitter.

...

> +required:
> +  - compatible
> +  - "#sound-dai-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    pwmdac-dit {
> +        compatible = "starfive,jh7110-pwmdac-dit";
> +        #sound-dai-cells = <0>;

BTW, I don't see any resources here. Neither in the driver. I think you
just added this for driver, not for a real hardware.

Best regards,
Krzysztof


  parent reply	other threads:[~2023-06-26 15:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26 11:09 [PATCH v1 0/5] Add PWM-DAC audio support for StarFive JH7110 RISC-V SoC Hal Feng
2023-06-26 11:09 ` [PATCH v1 1/5] ASoC: dt-bindings: Add StarFive JH7110 dummy PWM-DAC transmitter Hal Feng
2023-06-26 15:32   ` Krzysztof Kozlowski
2023-06-30  1:42     ` Hal Feng
2023-06-26 15:34   ` Krzysztof Kozlowski [this message]
2023-06-30  1:57     ` Hal Feng
2023-07-01  8:17       ` Krzysztof Kozlowski
2023-07-10  3:22         ` Hal Feng
2023-07-25  8:27           ` Hal Feng
2023-06-26 11:09 ` [PATCH v1 2/5] ASoC: codecs: Add StarFive JH7110 dummy PWM-DAC transmitter driver Hal Feng
2023-06-26 15:33   ` Krzysztof Kozlowski
2023-06-30  1:45     ` Hal Feng
2023-06-26 11:09 ` [PATCH v1 3/5] ASoC: dt-bindings: Add StarFive JH7110 PWM-DAC controller Hal Feng
2023-06-26 15:36   ` Krzysztof Kozlowski
2023-06-30  2:04     ` Hal Feng
2023-06-26 11:09 ` [PATCH v1 4/5] ASoC: starfive: Add JH7110 PWM-DAC driver Hal Feng
2023-06-26 12:25   ` Walker Chen
2023-06-26 11:09 ` [PATCH v1 5/5] riscv: dts: starfive: Add JH7110 PWM-DAC support Hal Feng
2023-06-26 12:11   ` Walker Chen
2023-06-26 15:37   ` Krzysztof Kozlowski
2023-06-30  2:12     ` Hal Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=006ddacd-0496-70d1-3310-99b16706de84@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=emil.renner.berthing@canonical.com \
    --cc=hal.feng@starfivetech.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    --cc=walker.chen@starfivetech.com \
    --cc=xingyu.wu@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®