From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B992EB64D9 for ; Thu, 29 Jun 2023 10:27:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230198AbjF2K1e (ORCPT ); Thu, 29 Jun 2023 06:27:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231831AbjF2K1X (ORCPT ); Thu, 29 Jun 2023 06:27:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 618931B0; Thu, 29 Jun 2023 03:27:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC5656151C; Thu, 29 Jun 2023 10:27:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC3F0C433C8; Thu, 29 Jun 2023 10:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688034441; bh=bPvP4Y25hHgu3neqxtUdrkLGAxIwJpwf6S6yIFQalOo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mg9DuhezoYMh/FWOnp+kn9eVapyic23i9t897m/wCgM5aQNwHZQcRgLHPPMJkjAks 0xuC2rRKBM19KSGUaPriv8F7GUlw2+Wf+l2n0o4mupP5i6qIA7NXzSNCjdCvK0WBYh u4GhlyOVp3yYICmzW8BMOoGteNOX1JVMWgCznNhq5zrvOgEy8HZklDzDoggC+MULRM f3WYN/U7H/RsVX84kOZKVkEGFQqN271oBsuLc9JpNIv/AdJlSSaZNO5C5qIPP44imm ecbW3hInCwKpS7hQlo/xnol5Tn2B8BrvNcoAYttcuS2NEqlgseuMbmJf43UtSs0+Hb mxznilpapIDmQ== Date: Thu, 29 Jun 2023 11:27:14 +0100 From: Mark Brown To: David Laight Cc: 'Sameer Pujar' , "robh+dt@kernel.org" , "krzk+dt@kernel.org" , "thierry.reding@gmail.com" , "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "jonathanh@nvidia.com" , "mkumard@nvidia.com" , "sheetal@nvidia.com" , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Oder Chiou Subject: Re: [PATCH v2 3/5] ASoC: rt5640: Fix sleep in atomic context Message-ID: <006fe704-4777-43f4-a85a-e181106ee31b@sirena.org.uk> References: <1688015537-31682-1-git-send-email-spujar@nvidia.com> <1688015537-31682-4-git-send-email-spujar@nvidia.com> <550e5c8f-0bfb-4ffc-9a43-1ecb153c6a02@sirena.org.uk> <953c899d04e543f681e44daad4ec2ff7@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gA2UFWZQXCDsCSqy" Content-Disposition: inline In-Reply-To: <953c899d04e543f681e44daad4ec2ff7@AcuMS.aculab.com> X-Cookie: Surprise due today. Also the rent. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gA2UFWZQXCDsCSqy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 29, 2023 at 10:21:06AM +0000, David Laight wrote: > From: Mark Brown > > What makes you think this is anything to do with audio glitches? The > > bug is literally what is described, it is not valid to sleep in atomic > > contexts and if we ever actually try things are likely to go badly. > What I mean is that deferring the ISR to process context > is likely to generate audio glitches on a busy system. This is an I2C connected CODEC. We're not doing anything with it in atomic context, and nothing it does is going to be *that* latency sensitive. --gA2UFWZQXCDsCSqy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSdXIEACgkQJNaLcl1U h9Be0wf/ROgGSAEbkgQzBxOmNgrw91eBaIwJJe+GoIsaTybqliz5eXrMv9B46p1F sixbkb16ATRlZBFC/1QUfV5ieLTC4USlazvajvIn9zLfhiCaYjDgLL7jtq1H6BkR pAVz5tEnETeZlnorDIw4rA/8xG8tZyYAdcCI97SsXq4czkCRf1n4Ec7L/IeBZ6D4 ENfM9wZ7LvCHJNw5/NqqhoKcGuJHaGDLjj0mY0BXzyIdnKfSGi/E/rFVHdlhgifV sh6kmwULkWuysVkdVyASn1Ogil7CH6aTmAH6g3vYp3dILODIoWJv5Zt13JOoNLR4 TnkzOJoTvEb8crrDMBNvTJysNuELrQ== =dbwv -----END PGP SIGNATURE----- --gA2UFWZQXCDsCSqy--