From: "Tomoya MORINAGA" <tomoya-linux@dsn.okisemi.com>
To: "Marc Kleine-Budde" <mkl@pengutronix.de>
Cc: "Wolfgang Grandegger" <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
"Wolfram Sang" <w.sang@pengutronix.de>,
"Christian Pellegrin" <chripell@fsfe.org>,
"Barry Song" <21cnbao@gmail.com>,
"Samuel Ortiz" <sameo@linux.intel.com>,
<socketcan-core@lists.berlios.de>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <andrew.chih.howe.khor@intel.com>,
<qi.wang@intel.com>, <margie.foster@intel.com>,
<yong.y.wang@intel.com>,
"Masayuki Ohtake" <masa-korg@dsn.okisemi.com>,
<kok.howg.ewe@intel.com>, <joel.clark@intel.com>
Subject: Re: [PATCH net-next-2.6 v3] can: Topcliff: PCH_CAN driver: Add Flow control,
Date: Fri, 19 Nov 2010 15:18:58 +0900 [thread overview]
Message-ID: <007401cb87b1$a773b3d0$66f8800a@maildom.okisemi.com> (raw)
In-Reply-To: <4CE27796.2000206@pengutronix.de>
On Tuesday, November 16, 2010 9:22 PM, Marc Kleine-Budde wrote :
Except the following, I have updated/resubmitted already .
>> static int pch_can_rx_poll(struct napi_struct *napi, int quota)
>> {
>> struct net_device *ndev = napi->dev;
>> struct pch_can_priv *priv = netdev_priv(ndev);
>> - struct net_device_stats *stats = &(priv->ndev->stats);
>> - u32 dlc;
>> u32 int_stat;
>> int rcv_pkts = 0;
^^^^
>can be removed...if you remove the += below
Since there is "goto" code, "=0" is better.
>> - spin_unlock_irqrestore(&priv->msgif_reg_lock, flags);
>> + pch_can_rw_msg_obj(&priv->regs->ifregs[1].creq, tx_obj_no);
>Still we have the busy waiting in the TX path. Maybe you can move the
>waiting before accessing the if[1] and remove the busy waiting here.
I can't understand your saying.
For transmitting data, calling pch_can_rw_msg_obj is mandatory.
---
Thanks,
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.
next prev parent reply other threads:[~2010-11-19 6:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 8:39 Tomoya MORINAGA
2010-11-16 11:04 ` Wolfgang Grandegger
2010-11-16 12:22 ` Marc Kleine-Budde
2010-11-19 6:18 ` Tomoya MORINAGA [this message]
[not found] ` <4CE64167.2030405@pengutronix.de>
2010-11-22 5:05 ` Tomoya MORINAGA
2010-11-22 8:27 ` Marc Kleine-Budde
2010-11-24 0:09 ` Tomoya MORINAGA
2010-11-24 12:34 ` Marc Kleine-Budde
2010-11-25 12:03 ` Tomoya MORINAGA
2010-11-25 12:08 ` Marc Kleine-Budde
2010-11-25 12:34 ` Tomoya MORINAGA
2010-11-25 12:40 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007401cb87b1$a773b3d0$66f8800a@maildom.okisemi.com' \
--to=tomoya-linux@dsn.okisemi.com \
--cc=21cnbao@gmail.com \
--cc=andrew.chih.howe.khor@intel.com \
--cc=chripell@fsfe.org \
--cc=davem@davemloft.net \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=w.sang@pengutronix.de \
--cc=wg@grandegger.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome