mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: "'Andrew Morton'" <akpm@linux-foundation.org>,
	"'LKML'" <linux-kernel@vger.kernel.org>
Cc: "'Richard Purdie'" <rpurdie@rpsys.net>,
	"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH 08/17] backlight: jornada720: fix checkpatch error and warning
Date: Tue, 16 Oct 2012 16:30:00 +0900	[thread overview]
Message-ID: <007901cdab70$0d7c28e0$28747aa0$%han@samsung.com> (raw)
In-Reply-To: <007101cdab6f$6c8bc030$45a34090$%han@samsung.com>

This patch fixes the checkpatch error and warning as below:

WARNING: line over 80 characters
ERROR: return is not a function, parentheses are not required

Also, long comments are fixed for the preferred style.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
 drivers/video/backlight/jornada720_bl.c  |   34 ++++++++++++++++++-----------
 drivers/video/backlight/jornada720_lcd.c |    3 +-
 2 files changed, 23 insertions(+), 14 deletions(-)

diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
index 16f593b..c23801c 100644
--- a/drivers/video/backlight/jornada720_bl.c
+++ b/drivers/video/backlight/jornada720_bl.c
@@ -48,7 +48,7 @@ static int jornada_bl_get_brightness(struct backlight_device *bd)
 
 	jornada_ssp_end();
 
-	return (BL_MAX_BRIGHT - ret);
+	return BL_MAX_BRIGHT - ret;
 }
 
 static int jornada_bl_update_status(struct backlight_device *bd)
@@ -58,7 +58,8 @@ static int jornada_bl_update_status(struct backlight_device *bd)
 	jornada_ssp_start();
 
 	/* If backlight is off then really turn it off */
-	if ((bd->props.power != FB_BLANK_UNBLANK) || (bd->props.fb_blank != FB_BLANK_UNBLANK)) {
+	if ((bd->props.power != FB_BLANK_UNBLANK) ||
+		(bd->props.fb_blank != FB_BLANK_UNBLANK)) {
 		ret = jornada_ssp_byte(BRIGHTNESSOFF);
 		if (ret != TXDUMMY) {
 			pr_info("brightness off timeout\n");
@@ -77,18 +78,23 @@ static int jornada_bl_update_status(struct backlight_device *bd)
 			goto out;
 		}
 
-		/* at this point we expect that the mcu has accepted
-		   our command and is waiting for our new value
-		   please note that maximum brightness is 255,
-		   but due to physical layout it is equal to 0, so we simply
-		   invert the value (MAX VALUE - NEW VALUE). */
-		if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness) != TXDUMMY) {
+		/*
+		 * at this point we expect that the mcu has accepted
+		 * our command and is waiting for our new value
+		 * please note that maximum brightness is 255,
+		 * but due to physical layout it is equal to 0, so we simply
+		 * invert the value (MAX VALUE - NEW VALUE).
+		 */
+		if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness)
+			!= TXDUMMY) {
 			pr_err("set brightness failed\n");
 			ret = -ETIMEDOUT;
 		}
 
-		/* If infact we get an TXDUMMY as output we are happy and dont
-		   make any further comments about it */
+		/*
+		 * If infact we get an TXDUMMY as output we are happy and dont
+		 * make any further comments about it
+		 */
 out:
 	jornada_ssp_end();
 
@@ -121,9 +127,11 @@ static int jornada_bl_probe(struct platform_device *pdev)
 
 	bd->props.power = FB_BLANK_UNBLANK;
 	bd->props.brightness = BL_DEF_BRIGHT;
-	/* note. make sure max brightness is set otherwise
-	   you will get seemingly non-related errors when
-	   trying to change brightness */
+	/*
+	 * note. make sure max brightness is set otherwise
+	 * you will get seemingly non-related errors when
+	 * trying to change brightness
+	 */
 	jornada_bl_update_status(bd);
 
 	platform_set_drvdata(pdev, bd);
diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
index 635b305..4b412cb 100644
--- a/drivers/video/backlight/jornada720_lcd.c
+++ b/drivers/video/backlight/jornada720_lcd.c
@@ -101,7 +101,8 @@ static int jornada_lcd_probe(struct platform_device *pdev)
 	struct lcd_device *lcd_device;
 	int ret;
 
-	lcd_device = lcd_device_register(S1D_DEVICENAME, &pdev->dev, NULL, &jornada_lcd_props);
+	lcd_device = lcd_device_register(S1D_DEVICENAME, &pdev->dev, NULL,
+					&jornada_lcd_props);
 
 	if (IS_ERR(lcd_device)) {
 		ret = PTR_ERR(lcd_device);
-- 
1.7.1



  parent reply	other threads:[~2012-10-16  7:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16  7:25 [PATCH 01/17] backlight: 88pm860x_bl: fix checkpatch warning Jingoo Han
2012-10-16  7:26 ` [PATCH 02/17] backlight: atmel-pwm-bl: " Jingoo Han
2012-10-16  7:27 ` [PATCH 03/17] backlight: corgi_lcd: fix checkpatch error and warning Jingoo Han
2012-10-16  7:27 ` [PATCH 04/17] backlight: da903x_bl: fix checkpatch warning Jingoo Han
2012-10-16  7:28 ` [PATCH 05/17] backlight: generic_bl: " Jingoo Han
2012-10-16  7:28 ` [PATCH 06/17] backlight: hp680_bl: fix checkpatch error and warning Jingoo Han
2012-10-16  7:29 ` [PATCH 07/17] backlight: ili9320: " Jingoo Han
2012-10-16  7:30 ` Jingoo Han [this message]
2012-10-16 15:46   ` [PATCH 08/17] backlight: jornada720: " Kristoffer Eriksson
2012-10-16  7:30 ` [PATCH 09/17] backlight: l4f00242t03: fix checkpatch warning Jingoo Han
2012-10-16  7:30 ` [PATCH 10/17] backlight: lm3630: " Jingoo Han
2012-10-16  7:31 ` [PATCH 11/17] backlight: locomolcd: fix checkpatch error and warning Jingoo Han
2012-10-16  7:31 ` [PATCH 12/17] backlight: omap1: fix checkpatch warning Jingoo Han
2012-10-16  7:32 ` [PATCH 13/17] backlight: pcf50633: " Jingoo Han
2012-10-16  7:32 ` [PATCH 14/17] backlight: platform_lcd: fix checkpatch error Jingoo Han
2012-10-16  7:33 ` [PATCH 15/17] backlight: tdo24m: fix checkpatch warning Jingoo Han
2012-10-16  7:33 ` [PATCH 16/17] backlight: tosa: fix checkpatch error and warning Jingoo Han
2012-10-16  7:34 ` [PATCH 17/17] backlight: vgg2432a4: fix checkpatch warning Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='007901cdab70$0d7c28e0$28747aa0$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®