From: Jingoo Han <jg1.han@samsung.com>
To: "'Anton Vorontsov'" <anton@enomsg.org>
Cc: "'David Woodhouse'" <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH 14/14] power: wm831x_backup: use devm_kzalloc()
Date: Mon, 11 Mar 2013 15:36:19 +0900 [thread overview]
Message-ID: <007e01ce1e22$bd376a90$37a63fb0$%han@samsung.com> (raw)
In-Reply-To: <007101ce1e21$f39efcc0$dadcf640$%han@samsung.com>
Use devm_kzalloc() to make cleanup paths more simple.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/power/wm831x_backup.c | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/power/wm831x_backup.c b/drivers/power/wm831x_backup.c
index d9cc169..58cbb00 100644
--- a/drivers/power/wm831x_backup.c
+++ b/drivers/power/wm831x_backup.c
@@ -169,7 +169,8 @@ static int wm831x_backup_probe(struct platform_device *pdev)
struct power_supply *backup;
int ret;
- devdata = kzalloc(sizeof(struct wm831x_backup), GFP_KERNEL);
+ devdata = devm_kzalloc(&pdev->dev, sizeof(struct wm831x_backup),
+ GFP_KERNEL);
if (devdata == NULL)
return -ENOMEM;
@@ -197,14 +198,8 @@ static int wm831x_backup_probe(struct platform_device *pdev)
backup->num_properties = ARRAY_SIZE(wm831x_backup_props);
backup->get_property = wm831x_backup_get_prop;
ret = power_supply_register(&pdev->dev, backup);
- if (ret)
- goto err_kmalloc;
return ret;
-
-err_kmalloc:
- kfree(devdata);
- return ret;
}
static int wm831x_backup_remove(struct platform_device *pdev)
@@ -213,7 +208,6 @@ static int wm831x_backup_remove(struct platform_device *pdev)
power_supply_unregister(&devdata->backup);
kfree(devdata->backup.name);
- kfree(devdata);
return 0;
}
--
1.7.2.5
next prev parent reply other threads:[~2013-03-11 6:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 6:30 [PATCH 01/14] power: 88pm860x_charger: drop kfree of devm_kzalloc'd data Jingoo Han
2013-03-11 6:31 ` [PATCH 02/14] power: max8925_power: use devm_kzalloc() Jingoo Han
2013-03-11 6:31 ` [PATCH 03/14] power: da9030_battery: " Jingoo Han
2013-03-11 6:32 ` [PATCH 04/14] power: da9052-battery: " Jingoo Han
2013-03-11 6:32 ` [PATCH 05/14] power: ds2760_battery: " Jingoo Han
2013-03-11 6:33 ` [PATCH 06/14] power: ds2780_battery: " Jingoo Han
2013-03-11 6:33 ` [PATCH 07/14] power: gpio-charger: " Jingoo Han
2013-03-11 6:34 ` [PATCH 08/14] power: isp1704_charger: " Jingoo Han
2013-03-11 6:34 ` [PATCH 09/14] power: max8903_charger: " Jingoo Han
2013-03-11 6:34 ` [PATCH 10/14] power: max8997_charger: " Jingoo Han
2013-03-11 6:35 ` [PATCH 11/14] power: max8998_charger: " Jingoo Han
2013-03-11 6:35 ` [PATCH 12/14] power: pcf50633-charger: " Jingoo Han
2013-03-11 6:35 ` [PATCH 13/14] power: rx51_battery: " Jingoo Han
2013-03-11 6:36 ` Jingoo Han [this message]
2013-04-01 6:29 ` [PATCH 01/14] power: 88pm860x_charger: drop kfree of devm_kzalloc'd data Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007e01ce1e22$bd376a90$37a63fb0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=anton@enomsg.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome