From: Jingoo Han <jg1.han@samsung.com>
To: "'David Rientjes'" <rientjes@google.com>,
"'Herbert Xu'" <herbert@gondor.hengli.com.au>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, "'Matt Mackall'" <mpm@selenic.com>
Subject: Re: [PATCH] hwrng: exynos - add CONFIG_PM_SLEEP to suspend/resume functions
Date: Fri, 22 Mar 2013 08:18:54 +0900 [thread overview]
Message-ID: <008301ce268a$74fb9470$5ef2bd50$%han@samsung.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1303211214230.5662@chino.kir.corp.google.com>
On Friday, March 22, 2013 4:17 AM, David Rientjes wrote:
>
> On Thu, 21 Mar 2013, Herbert Xu wrote:
>
> > > This patch adds CONFIG_PM_SLEEP to suspend/resume functions to fix
> > > the following build warning when CONFIG_PM_SLEEP is not selected.
> > >
> > > drivers/char/hw_random/exynos-rng.c:147:12: warning: 'exynos_rng_runtime_suspend' defined but not
> used [-Wunused-function]
> > > drivers/char/hw_random/exynos-rng.c:157:12: warning: 'exynos_rng_runtime_resume' defined but not
> used [-Wunused-function]
> > >
> > > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> >
> > Patch applied. Thanks.
>
> Nack, it causes build errors when CONFIG_PM_SLEEP is disabled:
>
> drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a
> function)
> drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a
> function)
OK, I see.
UNIVERSAL_DEV_PM_OPS is related to both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
Thus, CONFIG_PM_RUNTIME is also necessary.
I will send an additional patch, soon.
Best regards,
Jingoo Han
prev parent reply other threads:[~2013-03-21 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 5:46 Jingoo Han
2013-03-21 9:54 ` Herbert Xu
2013-03-21 19:17 ` David Rientjes
2013-03-21 23:18 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008301ce268a$74fb9470$5ef2bd50$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®