From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F6812E8DEB for ; Fri, 19 Dec 2025 21:34:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766180065; cv=none; b=IGVL124Fvs8oXtXLbGdbXsEUXOK1y6AD+tKJCOjWJIJRvcPwB/Sz22yl9+O8lBScW6cTwa4SrOvCwGEdFYXmicQjOqK6QxVVXsQvUiEZ6owy6Rl7gT3LLrSRuSzi+Zxq9Os9joN2aL1WI+f90C5JP7siTgB09386PP/Bb3L+i78= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766180065; c=relaxed/simple; bh=nyd1g6CvIGlrKzYvOsHmwPnVPCn93E0wfS69PVJVpBs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SU2YBI0fW8o5tiU0EezEd72uwqifrK69OQ+YRz8AWnrZ25kR0nDdlpZ28qJW1bbAMvxF08JUWFxFXQnDL/H0EcuEmzBRGlrpSmqxllTef82H6Z/rVONU6QW5nyQLr/YLTavj5xVy6OJbaE/4PDuPwK+mJogUrItK19o0/5wRbOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gRelEwD4; arc=none smtp.client-ip=209.85.215.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gRelEwD4" Received: by mail-pg1-f196.google.com with SMTP id 41be03b00d2f7-bc0d7255434so1343176a12.0 for ; Fri, 19 Dec 2025 13:34:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766180063; x=1766784863; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=t32XLNtILrSHOTsv1yzEwE7SsXS6lnNnHJdt9fn7tL4=; b=gRelEwD4GoWlWOkPaG7BOmN8aT/9HPaC9ND1AqE2rqeR1LSEmj1uB4CPOgI2wL5rRJ W52vtmHxEcCK5ZC1IrQSt+k9jGxVvMAgUVGgBNBePo3Iw2kwPnrxSn0ICFyGEhlqpLk/ 7Ly56ZOn3LFbs/0GivqzTKiUjLXNInfOHUmUyIztg5z/ezsSNpeeQnD3xe9GcpJerOLj D/ehegZSV5Q0SBO1XajgZ2bYxvu9VhcPJXXXr42VWTOC1p79kzIkdlv7SC3Qn8XrShJQ 7jEcSXVWh3lP3lGg91nqkOJaGDvW6VpJln9PYYRhufqtxdqJGnmlRuO05cQAuReP8LQD i5LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766180063; x=1766784863; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t32XLNtILrSHOTsv1yzEwE7SsXS6lnNnHJdt9fn7tL4=; b=cIp/deH1PU3uRkyQpuZ27X1whfmeKb55MQDw5XuTaAu702iSWBTtti5O777LRji2t7 DMwZjGzM95crIa6cjuUAcHyMeHhTHziaIZPIppU3v1jyrujuUflgtwaBvV9O5WUgTIEM tVZEh1q59YR/EF5fxvnIUBFUcUwr2adk3ndNZ/90Zu62lMegDEWgRlHBZwqVPMV49jB8 ondpmqw9l7dStzt8bkh1hkchDeCkhL4W25JWcEUIE2I1DrVw9T9Nf0gxEVHzLSJvwSWu 267UbIU/WSB/Ed+1pFC6Kt6dwyLqjul14VTkvKnWJg/pjHqyXOY0dY+fXOcpl8O1H7Xd Tcpw== X-Forwarded-Encrypted: i=1; AJvYcCUZXmAItZ05PRuDYyBteNIC3NoQspEfq/Z628sXmi2pKVOveBXZ290DZTbEFP+qDBRLhpafAAUo9zPvMMU=@vger.kernel.org X-Gm-Message-State: AOJu0YzbmtE+GC9Iski3a5Gr4QK5z5pnItExgHo4idLRf1xvOOFPbWMi lAlrDBqtMsRYnyqtZF0QoVf4Qh/klwYWhEHYo5wdp1ookFqoZpYaRlHt X-Gm-Gg: AY/fxX4bVeQABWlqchYS8uqYX7mH1XeXdIMOIa9/0QqdJw3+t65NTnlPbFdK+OpJ6NA 9SyVwLoeXFXIUAXvUMUPWsmcMmgr071HIl7hsiZ9LA3f8ONmUhO2HgJ86u2++/tVINSoqdnzBmY OwKRK8w3MMS7qohrrVBfDEGt35lsLJa2yl/tV2Ssjt21YjTcjwzaw4DFH1q8ElVfZtOjU23EV3P NM/JWK/4wTbMNWARLc54jpOrsSlYVSkmb6CRNYFczMw9cAtdonNKhRoEXMgGJ0jV2tnYt5mv/+p A8wcOyTRxbH1hjmg+WyEscZa0CwgU1u5f96yl7KrLyhxLpwOw12UL97UxsgbYXveomdnL/kAPTU nToMpQkkpjqIBz5CRNMLxte2MjcLTUaU/WDejes56pFnn7yLPj2JJPb5ICpbEBzJO/gUm0pLFlI Z26yGu0KofgIud4BMPQaxzXV315jGQ5PjeWsylxQhTfPLEUAPT2SW0nEfTTCSc0Y0ZEj1eMIqcA dUZuGfrhIsW90/MHGScv7/nFxkpxftikMeOYgVzBbXyXZ2556DOCVRTHpbKiOkr+GoU1YeCmGO0 Y0k= X-Google-Smtp-Source: AGHT+IH/ZQYDLQv8GePcj2Vm99oLZ3hFWnPTlzcp7/sSDr5k1uCEDV2wgPs8dBIcnq4Eb4hflvIUSg== X-Received: by 2002:a05:7300:b54b:b0:2b0:57ec:d1a1 with SMTP id 5a478bee46e88-2b05ec745e9mr4652797eec.25.1766180062475; Fri, 19 Dec 2025 13:34:22 -0800 (PST) Received: from ?IPV6:2a00:79e0:2e7c:8:5874:79f3:80da:a7a3? ([2a00:79e0:2e7c:8:5874:79f3:80da:a7a3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b05fe99410sm10155463eec.2.2025.12.19.13.34.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 13:34:21 -0800 (PST) Message-ID: <0088cc8c-b395-4659-854f-a6cc5df626ed@gmail.com> Date: Fri, 19 Dec 2025 14:34:19 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 08/36] locking/rwlock, spinlock: Support Clang's context analysis To: Marco Elver Cc: Peter Zijlstra , Boqun Feng , Ingo Molnar , Will Deacon , "David S. Miller" , Luc Van Oostenryck , Chris Li , "Paul E. McKenney" , Alexander Potapenko , Arnd Bergmann , Christoph Hellwig , Dmitry Vyukov , Eric Dumazet , Frederic Weisbecker , Greg Kroah-Hartman , Herbert Xu , Ian Rogers , Jann Horn , Joel Fernandes , Johannes Berg , Jonathan Corbet , Josh Triplett , Justin Stitt , Kees Cook , Kentaro Takeda , Lukas Bulwahn , Mark Rutland , Mathieu Desnoyers , Miguel Ojeda , Nathan Chancellor , Neeraj Upadhyay , Nick Desaulniers , Steven Rostedt , Tetsuo Handa , Thomas Gleixner , Thomas Graf , Uladzislau Rezki , Waiman Long , kasan-dev@googlegroups.com, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-sparse@vger.kernel.org, linux-wireless@vger.kernel.org, llvm@lists.linux.dev, rcu@vger.kernel.org References: <20251219154418.3592607-1-elver@google.com> <20251219154418.3592607-9-elver@google.com> <17723ae6-9611-4731-905c-60dab9fb7102@acm.org> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/19/25 2:02 PM, Marco Elver wrote: > On Fri, 19 Dec 2025 at 21:26, Bart Van Assche wrote: >> On 12/19/25 7:39 AM, Marco Elver wrote: >>> - extern void do_raw_read_lock(rwlock_t *lock) __acquires(lock); >>> + extern void do_raw_read_lock(rwlock_t *lock) __acquires_shared(lock); >> >> Given the "one change per patch" rule, shouldn't the annotation fixes >> for rwlock operations be moved into a separate patch? >> >>> -typedef struct { >>> +context_lock_struct(rwlock) { >>> arch_rwlock_t raw_lock; >>> #ifdef CONFIG_DEBUG_SPINLOCK >>> unsigned int magic, owner_cpu; >>> @@ -31,7 +31,8 @@ typedef struct { >>> #ifdef CONFIG_DEBUG_LOCK_ALLOC >>> struct lockdep_map dep_map; >>> #endif >>> -} rwlock_t; >>> +}; >>> +typedef struct rwlock rwlock_t; >> >> This change introduces a new globally visible "struct rwlock". Although >> I haven't found any existing "struct rwlock" definitions, maybe it's a >> good idea to use a more unique name instead. > > This doesn't actually introduce a new globally visible "struct > rwlock", it's already the case before. > An inlined struct definition in a typedef is available by its struct > name, so this is not introducing a new name > (https://godbolt.org/z/Y1jf66e1M). Please take another look. The godbolt example follows the pattern "typedef struct name { ... } name_t;". The "name" part is missing from the rwlock_t definition. This is why I wrote that the above code introduces a new global struct name. Bart.