From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754342AbcGLOTP (ORCPT ); Tue, 12 Jul 2016 10:19:15 -0400 Received: from emcscan.emc.com.tw ([192.72.220.5]:31353 "EHLO emcscan.emc.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbcGLOTN convert rfc822-to-8bit (ORCPT ); Tue, 12 Jul 2016 10:19:13 -0400 From: =?UTF-8?B?5buW5bSH5qau?= To: "'Dmitry Torokhov'" Cc: "'KT Liao'" , , , References: <1467979929-3409-1-git-send-email-kt.liao@emc.com.tw> <20160709002448.GI28589@dtor-ws> <019201d1db71$7986cd80$6c946880$@emc.com.tw> <20160711170321.GB26822@dtor-ws> In-Reply-To: <20160711170321.GB26822@dtor-ws> Subject: RE: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus touchapod which casue TP no funciton sometimes, the patch detect some specific touchpad and run a special initialize Date: Tue, 12 Jul 2016 22:19:07 +0800 Message-ID: <008a01d1dc48$5a2957f0$0e7c07d0$@emc.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQLKpoR7nOIB26vBx7/cLDmXA6rLzgI0XbmqAf0dVlABD/F8Sp35N4VA Content-Language: zh-tw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, -----Original Message----- From: 'Dmitry Torokhov' [mailto:dmitry.torokhov@gmail.com] Sent: Tuesday, July 12, 2016 1:03 AM To: 廖崇榮 Cc: 'KT Liao'; linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; phoenix@emc.com.tw Subject: Re: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus touchapod which casue TP no funciton sometimes, the patch detect some specific touchpad and run a special initialize On Mon, Jul 11, 2016 at 08:40:58PM +0800, 廖崇榮 wrote: > > + > > + error = data->ops->get_sm_version(client, &data->ic_type, > > + &data->sm_version); > > + if (error) > > + return false; > > That means we'd be fetching product ID and IC type twice when initializing the device. Can we come with a way to do it once? > [KT]:Because the elan_query_device_info() is behind the elan_initialize(). That's why I fetching product ID and IC type in the elan_initialize() > I will discuss with FW team and then execute elan_query_device_info() first to get product_id and ic_type. We might need to split fetching product ID and IC type form the rest of the device info. [KT] : ok, I will extract "product ID" and "IC type" to another query-device function. and it won't change original flow too much. Thanks. -- Dmitry