mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Antonio Borneo <antonio.borneo@foss.st.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [Linux-stm32] [PATCH] irqchip/stm32mp-exti: Use of_property_present() for non-boolean properties
Date: Tue, 5 Nov 2024 09:23:43 +0100	[thread overview]
Message-ID: <008a261f5407ab38bb025768624bdc6bd1869c84.camel@foss.st.com> (raw)
In-Reply-To: <20241104190836.278117-1-robh@kernel.org>

On Mon, 2024-11-04 at 13:08 -0600, Rob Herring (Arm) wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  drivers/irqchip/irq-stm32mp-exti.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-stm32mp-exti.c b/drivers/irqchip/irq-stm32mp-exti.c
> index 33e0cfdea654..cb83d6cc6113 100644
> --- a/drivers/irqchip/irq-stm32mp-exti.c
> +++ b/drivers/irqchip/irq-stm32mp-exti.c
> @@ -696,8 +696,7 @@ static int stm32mp_exti_probe(struct platform_device *pdev)
>         if (ret)
>                 return ret;
>  
> -       if (of_property_read_bool(np, "interrupts-extended"))
> -               host_data->dt_has_irqs_desc = true;
> +       host_data->dt_has_irqs_desc = of_property_present(np, "interrupts-extended");
>  
>         return 0;
>  }

Reviewed-by: Antonio Borneo <antonio.borneo@foss.st.com>

Thanks,
Antonio

  reply	other threads:[~2024-11-05  8:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 19:08 Rob Herring (Arm)
2024-11-05  8:23 ` Antonio Borneo [this message]
2024-11-06 23:32 ` [tip: irq/core] " tip-bot2 for Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=008a261f5407ab38bb025768624bdc6bd1869c84.camel@foss.st.com \
    --to=antonio.borneo@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®