From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD9BC433EF for ; Thu, 23 Sep 2021 13:32:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1206C61164 for ; Thu, 23 Sep 2021 13:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241246AbhIWNdk (ORCPT ); Thu, 23 Sep 2021 09:33:40 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:44556 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231974AbhIWNdi (ORCPT ); Thu, 23 Sep 2021 09:33:38 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id ED5C540291 for ; Thu, 23 Sep 2021 13:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632403925; bh=biNupszeS11Ffqm/B+oAmn3pnoiB+8ke0AHaHHLBLkQ=; h=Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=uqsDSwLSR26qeqzFQeHQZweiL9wqqe4nF/2MRzf+SQbBb739NSeJD4siSRuTW/w3J V5dXFjDicadRroXKexFN0eMrkV07RqDyeUtTRZmVss/NA8/xlm0mDB1mE462w9kdvU j45e8jD2yN8fUWt7yfcahzqFYMeW+KawfnclF9UTlCgUxBEdn5rc0KHfeJq3UH5D9Z 6EzliEUZ5VY6VVeD0k90t6UZe4G015+cxIFhgOk/rY4xZZK/RcT41PJIkwoV1Zl8W7 8hujY0QDM4LAzoC5L9SG6IurbV7+8MPAjwf6oWxzXwc0KBBawpSV4mfATsCLzE1xzZ 9vyQXJYktq4iA== Received: by mail-wr1-f70.google.com with SMTP id m18-20020adfe952000000b0015b0aa32fd6so5139903wrn.12 for ; Thu, 23 Sep 2021 06:32:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=biNupszeS11Ffqm/B+oAmn3pnoiB+8ke0AHaHHLBLkQ=; b=3fYt6WmNQ70ApQCbQ8UNbQL+n59EuB36rc6AR3b78mmShIKP2A4Fm/Y993kFjVI77t kwOH3VoMEmBowzQkf461GQ4a66CwQvLrSbuumea6LF01NXVy457PwH2IUE5/sC/mdRDK GFJYQC6+xNO8Bd+cT8z+ir6phO+Xh5qxP5Lu66Qqun7CUPLlAZL/YX0qpZWmwxZO2rkp E6IO7gHb/gr+mOxM+6q+56nKdbkNl+35laXyzepjH5Zo/lURNnfv9krHWMnNnhIWU6e/ y9MRYW4Its4gWOs0QgWcpmsY0kHpfXJciuMkZ8eID91h4rRKTe5wwHwKHxjBxQ7nmCNV zSRQ== X-Gm-Message-State: AOAM532kQJ0TM/yDkctKIxbQrjk7T9oJm2vppuilavSPwQimqGMOfKsr Rkt+9qnj9gzfkPa8m+jr8xAO2d2Co9vVQGkF669kz2WC8t1wbOniXn18KTxsEnx8NxFOYE+IiG1 DA99Pf0o8/Y8xSNI2AjMnaXcOsDI4Njo/g6M/5AcYJQ== X-Received: by 2002:a05:6000:2af:: with SMTP id l15mr5158645wry.129.1632403925641; Thu, 23 Sep 2021 06:32:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5tlOMKjo3eto+NuBuyW5Olj/sQBjkgJBO9qLihHpCc1YBmYn+8lzfFTbdBPPGXM5Q8neptw== X-Received: by 2002:a05:6000:2af:: with SMTP id l15mr5158617wry.129.1632403925481; Thu, 23 Sep 2021 06:32:05 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id i9sm9728035wmi.44.2021.09.23.06.32.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 06:32:04 -0700 (PDT) Subject: Re: [PATCH v2 1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration To: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Rob Herring , Frank Rowand , Christophe Leroy , "Aneesh Kumar K.V" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20210922160436.130931-1-krzysztof.kozlowski@canonical.com> <87v92rl95e.fsf@mpe.ellerman.id.au> From: Krzysztof Kozlowski Message-ID: <008b61ee-ddc1-ad99-a660-2e0e6c3ae533@canonical.com> Date: Thu, 23 Sep 2021 15:32:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87v92rl95e.fsf@mpe.ellerman.id.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/09/2021 15:21, Michael Ellerman wrote: > Krzysztof Kozlowski writes: >> g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c, >> so it should have a declaration to fix W=1 warning: >> >> arch/powerpc/platforms/powermac/feature.c:1533:6: >> error: no previous prototype for ‘g5_phy_disable_cpu1’ [-Werror=missing-prototypes] >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> Changes since v1: >> 1. Drop declaration in powermac/smp.c > > Sorry I missed v1, so I'm going to ask for more changes :} > >> arch/powerpc/include/asm/pmac_feature.h | 4 ++++ > > Putting it here exposes it to the whole kernel, but it's only needed > inside arch/powerpc/platforms/powermac. > > The right place for the prototype is arch/powerpc/platforms/powermac/pmac.h, > which is for platform internal prototypes. I'll fix it up. > >> arch/powerpc/platforms/powermac/smp.c | 2 -- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/arch/powerpc/include/asm/pmac_feature.h b/arch/powerpc/include/asm/pmac_feature.h >> index e08e829261b6..7703e5bf1203 100644 >> --- a/arch/powerpc/include/asm/pmac_feature.h >> +++ b/arch/powerpc/include/asm/pmac_feature.h >> @@ -143,6 +143,10 @@ >> */ >> struct device_node; >> >> +#ifdef CONFIG_PPC64 >> +void g5_phy_disable_cpu1(void); >> +#endif /* CONFIG_PPC64 */ > > The ifdef around the prototype doesn't gain much, and is extra visual > noise, so I'd rather without it. Sure. Best regards, Krzysztof