From: Xi Ruoyao <xry111@xry111.site>
To: Youling Tang <tangyouling@loongson.cn>, loongarch@lists.linux.dev
Cc: linux-kernel@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
Huacai Chen <chenhuacai@kernel.org>
Subject: Re: [PATCH 1/5] LoongArch: Add section of GOT for kernel module
Date: Thu, 28 Jul 2022 17:02:58 +0800 [thread overview]
Message-ID: <00914cf65b64e06f370213fdc079111aa2a27145.camel@xry111.site> (raw)
In-Reply-To: <849f514e-f78a-72a2-b94e-6974074b75eb@loongson.cn>
On Thu, 2022-07-28 at 16:29 +0800, Youling Tang wrote:
> On 07/28/2022 12:26 AM, Xi Ruoyao wrote:
> > + mod->arch.got.shdr->sh_type = SHT_NOBITS;
> > + mod->arch.got.shdr->sh_flags = SHF_ALLOC;
> > + mod->arch.got.shdr->sh_addralign = L1_CACHE_BYTES;
> > + mod->arch.got.shdr->sh_size = (num_plts + 1) *
> > sizeof(struct plt_entry);
> > + mod->arch.got.num_entries = 0;
> > + mod->arch.got.max_entries = num_plts;
> Hi, Ruoyao
>
> We should use num_gots instead of num_plts when creating .got
> section.
Yes, it's a stupid error and I'll fix it in V2.
But why didn't this cause a malfunction on my system? :(.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-07-28 9:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 16:24 [PATCH 0/5] LoongArch: Support new relocation types Xi Ruoyao
2022-07-27 16:26 ` [PATCH 1/5] LoongArch: Add section of GOT for kernel module Xi Ruoyao
[not found] ` <849f514e-f78a-72a2-b94e-6974074b75eb@loongson.cn>
2022-07-28 9:02 ` Xi Ruoyao [this message]
2022-07-28 9:21 ` Youling Tang
2022-07-28 10:53 ` Xi Ruoyao
2022-07-27 16:27 ` [PATCH 2/5] LoongArch: Support R_LARCH_SOP_PUSH_GPREL relocation type in " Xi Ruoyao
2022-07-27 16:28 ` [PATCH 3/5] LoongArch: Support relocation against _GLOBAL_OFFSET_TABLE_ Xi Ruoyao
2022-07-28 1:02 ` Jinyang He
2022-07-28 6:41 ` Xi Ruoyao
2022-07-28 9:14 ` Jinyang He
2022-07-28 10:57 ` Xi Ruoyao
2022-07-28 11:21 ` Jinyang He
2022-07-27 16:29 ` [PATCH 4/5] LoongArch: Stop using undocumented assembler options Xi Ruoyao
2022-07-28 9:46 ` Youling Tang
2022-07-28 10:58 ` Xi Ruoyao
2022-07-27 16:31 ` [PATCH 5/5] LoongArch: Support modules with new relocation types Xi Ruoyao
2022-07-27 16:46 ` [PATCH 0/5] LoongArch: Support " Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00914cf65b64e06f370213fdc079111aa2a27145.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=tangyouling@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®