From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Vincent Guittot'" <vincent.guittot@linaro.org>,
"'Liu, Chuansheng'" <chuansheng.liu@intel.com>
Cc: "'Zhang, Jun'" <jun.zhang@intel.com>,
"'Ingo Molnar'" <mingo@redhat.com>,
"'Peter Zijlstra'" <peterz@infradead.org>,
"'linux-kernel'" <linux-kernel@vger.kernel.org>,
"'Liu, Changcheng'" <changcheng.liu@intel.com>
Subject: Re: [PATCH] sched/fair: fix select_task_rq_fair return -1
Date: Thu, 04 Dec 2014 19:10:27 +0800 [thread overview]
Message-ID: <009501d00fb2$e90c30f0$bb2492d0$@alibaba-inc.com> (raw)
In-Reply-To: <CAKfTPtDWpu=nEQ7yyt86y7EUL0=rXGHj7i4KYGH=TSuoJfkEdw@mail.gmail.com>
>
> The change below will give a similar behavior than 3.18 for 3.14 and
> we still match the condition if (new_cpu == -1 || new_cpu == cpu) in
>
And -1 is no longer needed.
> order to go in the child level
>
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -4151,7 +4151,7 @@ static int
> find_idlest_cpu(struct sched_group *group, struct task_struct *p, int this_cpu)
> {
> unsigned long load, min_load = ULONG_MAX;
> - int idlest = -1;
> + int idlest = this_cpu;
> int i;
>
> /* Traverse only the allowed CPUs */
>
next prev parent reply other threads:[~2014-12-04 11:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 9:05 Hillf Danton
2014-12-04 9:22 ` Zhang, Jun
2014-12-04 9:32 ` Hillf Danton
2014-12-04 10:07 ` Vincent Guittot
2014-12-04 10:23 ` Liu, Chuansheng
2014-12-04 10:43 ` Vincent Guittot
2014-12-04 11:10 ` Hillf Danton [this message]
2014-12-04 12:10 ` Vincent Guittot
-- strict thread matches above, loose matches on Subject: below --
2014-12-04 4:27 jun.zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009501d00fb2$e90c30f0$bb2492d0$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=changcheng.liu@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=jun.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome