From: Jingoo Han <jg1.han@samsung.com>
To: Daniel Jeong <gshark.jeong@gmail.com>
Cc: "'Daniel Jeong'" <daniel.jeong@ti.com>,
"'Andrew Morton'" <akpm@linux-foundation.org>,
"'Richard Purdie'" <rpurdie@rpsys.net>,
linux-kernel@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH v1] backlight-lm3630-apply chip revision
Date: Mon, 29 Jul 2013 10:58:33 +0900 [thread overview]
Message-ID: <009701ce8bff$21cae730$6560b590$@samsung.com> (raw)
In-Reply-To: <1374829330-20603-1-git-send-email-daniel.jeong@ti.com>
On Friday, July 26, 2013 6:02 PM, Daniel Jeong wrote:
> Subject: [PATCH v1] backlight-lm3630-apply chip revision
Please don't use this subject, as I mentioned.
Also, this patch version is v2.
Thus, when you send the next version of this patch,
you should use the subject as below:
[PATCH v3] backlight: lm3630: apply chip revision
According to 'Documentation/SubmittingPatches',
15) The canonical patch format
The canonical patch subject line is:
Subject: [PATCH 001/123] subsystem: summary phrase
>
> The LM3630 chip was revised by TI and chip name was also changed to LM3630A.
> And register map, default values and intiial sequences are changed.
Looks good.
> lm3630_bl.c and .h files are deleted
> lm3630_bla.c and .h files are added
Fix the typo: lm3630_bla.c -> lm3630a_bl.c
The following is simpler.
lm3630_bl.{c,h} files are changed to lm3630a_bl.{c,h}.
> www.ti.com
>
Please, don't add meaningless commit message.
If you want to mention web address of your company,
please mention what it means as below:
The full datasheets are available from TI website:
http://www.ti.com/product/lm3630a
> Signed-off-by: daniel jeong <daniel.jeong@ti.com>
Please use upper case as below:
Signed-off-by: Daniel Jeong <daniel.jeong@ti.com>
^^^ ^^^
In my opinion, you have to fix your .gitconfig file as below:
[user]
email = daniel.jeong@ti.com
name = Daniel Jeong
Daniel Jeong,
Please, read the './Documentation/SubmittingPatches', before you send
your patch.
Best regards,
Jingoo Han
> ---
> drivers/video/backlight/Kconfig | 6 +-
> drivers/video/backlight/Makefile | 2 +-
> drivers/video/backlight/lm3630_bl.c | 475 -----------------------------
> drivers/video/backlight/lm3630a_bl.c | 482 ++++++++++++++++++++++++++++++
> include/linux/platform_data/lm3630_bl.h | 57 ----
> include/linux/platform_data/lm3630a_bl.h | 65 ++++
> 6 files changed, 551 insertions(+), 536 deletions(-)
> delete mode 100644 drivers/video/backlight/lm3630_bl.c
> create mode 100644 drivers/video/backlight/lm3630a_bl.c
> delete mode 100644 include/linux/platform_data/lm3630_bl.h
> create mode 100644 include/linux/platform_data/lm3630a_bl.h
>
prev parent reply other threads:[~2013-07-29 1:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 9:02 daniel jeong
2013-07-29 1:58 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009701ce8bff$21cae730$6560b590$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.jeong@ti.com \
--cc=gshark.jeong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®