From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBE8A8635E; Thu, 13 Feb 2025 01:55:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739411745; cv=none; b=AeqX8i7HVfvN4DF6/paiU6Vq3f31p941IiKPOJS9Hwv1HSuiKuENYXJEt9fsdcGXIfjFOjqSCZwV1mbp9H1EUeYFpxpSTyMkDl9nEsTH0+CJzkfnj4q8xE8DG6XySRCRy+n/hi3mVM2pjfkHI70hyWUDZxfa5R1aggcM0CyWfJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739411745; c=relaxed/simple; bh=iTSClWmyDqTMwzKfbdlDXnb2TNVtqMpl6wDetfIo41E=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=PN3AbuNo/kL9XZvIjC61B3Eo0FBaG2X9YxlT/GHl2ZXL5e2qmR8eRkUK+9OI5DfTwYHnQwn8/fEU26lULc6lIViuVTGEokphJ8fOk7PK9hHpHZ3bmeC3fPd1g/ynQ1SY7BeJIb50M1DoffSPqlu4pykQsuWSWpdVTo+zSFfr7Y8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4YtdTf50VqzkXKD; Thu, 13 Feb 2025 09:52:06 +0800 (CST) Received: from kwepemh100008.china.huawei.com (unknown [7.202.181.93]) by mail.maildlp.com (Postfix) with ESMTPS id ED4271800B6; Thu, 13 Feb 2025 09:55:39 +0800 (CST) Received: from [10.67.121.90] (10.67.121.90) by kwepemh100008.china.huawei.com (7.202.181.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 13 Feb 2025 09:55:39 +0800 Message-ID: <0097a9a3-fe61-4200-9a54-5a9c81d3219c@huawei.com> Date: Thu, 13 Feb 2025 09:55:38 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/8] Support for autonomous selection in cppc_cpufreq To: , , , , , , , CC: , , , , , , , , , , , References: <20250206131428.3261578-1-zhenglifeng1@huawei.com> From: "zhenglifeng (A)" In-Reply-To: <20250206131428.3261578-1-zhenglifeng1@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh100008.china.huawei.com (7.202.181.93) On 2025/2/6 21:14, Lifeng Zheng wrote: > Add sysfs interfaces for CPPC autonomous selection in the cppc_cpufreq > driver. > > The patch series is organized in two parts: > > - patch 1-5 refactor out the general CPPC register get and set functions > in cppc_acpi.c > > - patches 6-8 expose sysfs files for users to control CPPC autonomous > selection when supported > > Changelog: > > v5: > > - add more explanation to the commit logs and comments > - change REG_OPTIONAL from bin to hex > - split patch 2 into 3 smaller patches > - remove CPPC_REG_VAL_READ() and CPPC_REG_VAL_WRITE() macros > - move the modification part in patch 5 into a separate patch > - rename the sysfs file from "energy_perf" to > energy_performance_preference_val > > v4: > > - add REG_OPTIONAL and IS_OPTIONAL_CPC_REG to judge if a cpc register is > an optional one > - check whether the register is optional before CPC_SUPPORTED check in > cppc_get_reg_val() and cppc_set_reg_val() > - check the register's type in cppc_set_reg_val() > - add macros to generally implement registers getting and setting > functions > - move some logic codes from cppc_cpufreq.c to cppc_acpi.c > - replace cppc_get_auto_sel_caps() by cppc_get_auto_sel() > > v3: > > - change cppc_get_reg() and cppc_set_reg() name to cppc_get_reg_val() and > cppc_set_reg_val() > - extract cppc_get_reg_val_in_pcc() and cppc_set_reg_val_in_pcc() > - return the result of cpc_read() in cppc_get_reg_val() > - add pr_debug() in cppc_get_reg_val_in_pcc() when pcc_ss_id < 0 > - rename 'cpunum' to 'cpu' in cppc_get_reg_val() > - move some macros from drivers/cpufreq/cppc_cpufreq.c to > include/acpi/cppc_acpi.h with a CPPC_XXX prefix > > v2: > > - fix some incorrect placeholder > - change kstrtoul to kstrtobool in store_auto_select > > Lifeng Zheng (8): > ACPI: CPPC: Add IS_OPTIONAL_CPC_REG macro to judge if a cpc_reg is > optional > ACPI: CPPC: Optimize cppc_get_perf() > ACPI: CPPC: Rename cppc_get_perf() to cppc_get_reg_val() > ACPI: CPPC: Add cppc_set_reg_val() > ACPI: CPPC: Refactor register value get and set ABIs > ACPI: CPPC: Modify cppc_get_auto_sel_caps() to cppc_get_auto_sel() > ACPI: CPPC: Add three functions related to autonomous selection > cpufreq: CPPC: Support for autonomous selection in cppc_cpufreq > > .../ABI/testing/sysfs-devices-system-cpu | 54 ++++ > drivers/acpi/cppc_acpi.c | 303 +++++++++++------- > drivers/cpufreq/amd-pstate.c | 3 +- > drivers/cpufreq/cppc_cpufreq.c | 109 +++++++ > include/acpi/cppc_acpi.h | 30 +- > 5 files changed, 372 insertions(+), 127 deletions(-) > Gentle ping. Attach discussions of previous versions: v1: https://lore.kernel.org/all/20241114084816.1128647-1-zhenglifeng1@huawei.com/ v2: https://lore.kernel.org/all/20241122062051.3658577-1-zhenglifeng1@huawei.com/ v3: https://lore.kernel.org/all/20241216091603.1247644-1-zhenglifeng1@huawei.com/ v4: https://lore.kernel.org/all/20250113122104.3870673-1-zhenglifeng1@huawei.com/