From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0031C4332F for ; Wed, 8 Nov 2023 03:31:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234748AbjKHDbw (ORCPT ); Tue, 7 Nov 2023 22:31:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234445AbjKHDbu (ORCPT ); Tue, 7 Nov 2023 22:31:50 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B49E810F8; Tue, 7 Nov 2023 19:31:47 -0800 (PST) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SQ9W94fPJzMmY9; Wed, 8 Nov 2023 11:27:17 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 8 Nov 2023 11:31:45 +0800 Subject: Re: [PATCH net v2] page_pool: Add myself as page pool reviewer in MAINTAINERS To: Jakub Kicinski CC: , , , , Jesper Dangaard Brouer , Ilias Apalodimas References: <20231107123825.61051-1-linyunsheng@huawei.com> <20231107094959.556ffe53@kernel.org> From: Yunsheng Lin Message-ID: <0098508e-59ab-5633-3725-86f1febc1480@huawei.com> Date: Wed, 8 Nov 2023 11:31:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20231107094959.556ffe53@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/11/8 1:49, Jakub Kicinski wrote: > On Tue, 7 Nov 2023 20:38:24 +0800 Yunsheng Lin wrote: >> I have added frag support for page pool, made some improvement >> for it recently, and reviewed some related patches too. >> >> So add myself as reviewer so that future patch will be cc'ed >> to my email. > > Not sure what to do about this, it feels somewhat wrong to add > as a reviewer someone who seem to not follow our basic process > requirements: > > https://www.kernel.org/doc/html/next/process/maintainer-netdev.html I reread the above doc in order not to miss anything obvious again:( I suppose basic process requirements mean: 1. designate your patch to a tree - [PATCH net] or [PATCH net-next] 2. don't repost your patches within one 24h period For 1, somehow I got the impression that changing to MAINTAINERS can be targetted to net branch, so that the change can flow to other main trees quickly, maybe I was wrong? For 2, yes, maybe I should stick to the rule even if it is a simple patch and obivous format error. Please correct me if there is anything else I missed. > > :( > > . >