From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5908721D5AA for ; Sat, 24 Jan 2026 05:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769231908; cv=none; b=AybRWZM3KCta8z7XfQrCOCSyU5FXoKyrTyZPiMmUMOFTs/JWe9qR4QlrSxr/xJjIq97LrqS5Xjecxwggr7oif2S331fXRk2FLCjIaVQlI60oP1jLk3GKM3saLK/1JiopJE8OAnHGoC1u8CO+UtooFC07bnQCWTW2POVHwykhv0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769231908; c=relaxed/simple; bh=rPtHryY0q9AVLq9N0aEIaze3I2zH4NeZeRcE+2JStw4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ieLXbdS+5xJUCwVMqMOEpq5WLhfilma7KK/FnYRzyapYtCZsJPY5YUpnUsWaVhHOzv2PPZ1BxHLq9Y2QOYTo0kklxrz/2jKqEundasYsSgCC0gXivmVeq6PwayhUKG/GA54rHx4ac6Mo5l6bbkrjMssd7/rwmIu+GbG9ziQ6waM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ackw3ouh; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ackw3ouh" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-8c6ac42b91eso352448685a.3 for ; Fri, 23 Jan 2026 21:18:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769231906; x=1769836706; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uAVsETK21+kGnCxqlDEtp4ioX9WXTvhY2/OchwRYyU8=; b=Ackw3ouh56qyan5nZtm/nns8lyA/jtWL2WNFokrGIQ0sXWwNkJTA9dPt3HH2zGfZoU QXym18J66fqH2Wz7O6FwEQXP4cK10ekZXX+bN7h4Y9h4fRdXWwkT1d2ll4Qig6L0gGoD Q6EKBptf+Mv2DTLTF8FMMxl4TggeU6wZvDpvq34Qsr1ylwACHEYdW7xIzjEpK0SwExeA YruzR9F0PPVsotGkKFkimpMMi18bimMZtx1dFKzLzkbugWXJX+59D5oBmTY/mOwe9VJN WhN9OLKo0ym9sg2bH/T5t0B8/FnDulk1H4AGEvB8PvJw/5V20Tef0l+oZiJqb2aOsdE6 rb9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769231906; x=1769836706; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uAVsETK21+kGnCxqlDEtp4ioX9WXTvhY2/OchwRYyU8=; b=WWVPPsqYtrQmopkOz6G2IrrlhOj/5cgzCnOuIDJzN7aTg0h3B1aucE8IeVmsgDVp6y OghvQ/2a1WU9rxwXogwKpIgD9njEzQNj6v4Aw87fyun/aJTmDUzHG4fdyCAkXPbn39Oz 1DeIA2qYlSSsfCW+LosNMKBEkQWqnUxtas1M/EIenawpXJZC8drRhHd1gDUqChStqbZz a0b1OFnVWIrOTrOGEwj4QuBf51QhiWLlKO4ekMiZR02LT1LYjQgOOkpMDygkC1C6/cF5 j0ARYuoi4/ZZHIFRqvp2vv4xCupEWQhWzVy4HPjHNTsPXwP4QnFyyPUmlt9QjU/hJ48g UAxw== X-Forwarded-Encrypted: i=1; AJvYcCXxBrpHbbBa0zKk5f9mroVgBQ0d+Qksb48AW+huOlqL8hyk7PXmWvUtlTppk7BtaoHT8XnwFBNZa7s+XJ4=@vger.kernel.org X-Gm-Message-State: AOJu0YxCahzhtki8KSREklSDm9VuAlF4I94/O6QqMY4CIy9Kb9jJRlAc 2B8C1R1eKxn3/WCxPmeWj0xk1mCqt2cgZdOZA4ZhNKH3S0RAd17iNP29 X-Gm-Gg: AZuq6aLo3MkBlz9TTduj3usbsGbrjMcEz+GApUkwA+6qLRzLcTtQoROCedXmuVFbOwn 3b7iaH4Kbzhr6Kk5Tob1w3b9lSYQ4N0Jt0KiITTrpXUUPIuApQ84ZIw8a5ZD110ogGOhaM7dzO3 N7y9v3sdbQJ7mE04MTAFgWDNFBj6MZy2E0+FzxqNflNn/q+2FsZq8e8NcZvCVx9OJuKG/NFBN2j tRxIbl086EqmXRN1+Z5SvlgJNQ5j3s/6ENY5SRe1Ue+BsIAZPaPNVEh4t+OKPes0hrB7TseEOgw mJ/o5Zl0N+6djGCsplF5ZvI/54kYwUpf0s8v4uRac+JZFL1qufSmC8QeP1GHiNgLsqE+AT/2d1i HL7lnw83JOmQYdXlWA5HTFeCzHO6BcGOyZf55Mw6HeDgFO1cNc0PCIFXaYamfFfgun6MWaqztgD O5hqSsOmcWFRES/UqOwL1LQiLhTueCvjHM3xk= X-Received: by 2002:a05:7301:1015:b0:2ae:5db9:f32c with SMTP id 5a478bee46e88-2b739b6d1bdmr2095282eec.26.1769230365229; Fri, 23 Jan 2026 20:52:45 -0800 (PST) Received: from [172.16.0.242] ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b73aa22707sm5548789eec.29.2026.01.23.20.52.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jan 2026 20:52:44 -0800 (PST) Message-ID: <009aefc4-fbc9-4f91-9230-23d18c281bf3@gmail.com> Date: Fri, 23 Jan 2026 20:57:23 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] dt-bindings: ethernet: eswin: add clock sampling control To: Andrew Lunn Cc: Krzysztof Kozlowski , =?UTF-8?B?5p2O5b+X?= , devicetree@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, rmk+kernel@armlinux.org.uk, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ningyu@eswincomputing.com, linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com, weishangjuan@eswincomputing.com References: <20260109080601.1262-1-lizhi2@eswincomputing.com> <20260109080859.1285-1-lizhi2@eswincomputing.com> <00b7b42f-2f9d-402a-82f0-21641ea894a1@lunn.ch> <308b676.2d03.19bb0caebed.Coremail.lizhi2@eswincomputing.com> <59cec617-0189-4dc3-bc3f-6346155a62ae@lunn.ch> <4e2a55e7.3662.19be8cb9c3c.Coremail.lizhi2@eswincomputing.com> <43923bf9-6202-4147-8eac-5bd7bb653fd4@gmail.com> Content-Language: en-US From: Bo Gan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Andrew, On 1/23/26 11:43, Andrew Lunn wrote: > On Fri, Jan 23, 2026 at 02:47:18AM -0800, Bo Gan wrote: >> Hi Krzysztof, >> >> On 1/23/26 02:07, Krzysztof Kozlowski wrote: >>> On 23/01/2026 08:39, Bo Gan wrote: >>>>> I assume the address of the interface is fixed. So you can just key >>>>> off that to distinguish the two instances. >>>>> >>>>> Since this is an internal property, not a board property, it is not >>>>> clear it actually belongs on DT. >>>>> >>>>> Andrew >>>> >>>> IMO, they should be in DT to provide maximum flexibility. The SoC .dtsi >>> >>> This is not the purpose of DT. Please rather use arguments in terms of >>> DT rules (see docs, presentations). >>> >> Any examples? links? Thank you for your patience. >> >> I'd say if the board .dts never overrides the eswin,rx-clk-invert, (E.g., >> the SoC .dtsi has rx-clk-invert, later the board /delete-property/'s it) >> then yes, it can be treated as something inherent to the mac, and then >> "use arguments in terms of DT rules". I was thinking about use cases like: >> https://lore.kernel.org/all/20230714104521.18751-3-samin.guo@starfivetech.com/ > > Your device should be compliant with the RGMII standard by > default. There should not be a DT property to ask it nicely to follow > the standard. > > Properties like > > motorcomm,tx-clk-adj-enabled; > motorcomm,tx-clk-100-inverted; > motorcomm,tx-clk-1000-inverted; > > are for broken boards which break the standard and require the MAC do > also break the standard so that everything works. We should not start > out with the assumption you need to support broken boards which ignore > the standard. My reading of https://lore.kernel.org/all/308b676.2d03.19bb0caebed.Coremail.lizhi2@eswincomputing.com/ is that the eth1 MAC is already breaking the standard at SoC level, and the boards can un-break it or break it even more. Hence, even for proper designed board, SoC .dtsi still needs eswin,rx-clk-invert (for *eth1*). For broken boards, they may require eswin,rx-clk-invert for *eth0*, even though SoC doesn't mandate. For *eth1* broken boards might have to /delete-property/ it and use eswin,tx-clk-invert or something else. It's clearer to have all these parameters visible and explicit in DT. ESWIN, please correct me if I'm wrong. P.S. I'm not affiliated to ESWIN, but I do own eic7700/hifive-premier board, and I can talk to someone who owns eic7700/megrez. I can help validating ESWIN's patches independently. > > Andrew > Bo